[RESEND PATCH V5 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")

Oleksandr Tyshchenko posted 2 patches 2 years, 11 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/1621626361-29076-1-git-send-email-olekstysh@gmail.com
There is a newer version of this series
docs/man/xl-disk-configuration.5.pod.in   |  27 +
tools/include/libxl.h                     |   6 +
tools/libs/light/libxl_arm.c              | 133 ++++-
tools/libs/light/libxl_device.c           |  38 +-
tools/libs/light/libxl_disk.c             |  99 +++-
tools/libs/light/libxl_types.idl          |   4 +
tools/libs/light/libxl_types_internal.idl |   1 +
tools/libs/light/libxl_utils.c            |   2 +
tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++---------------
tools/libs/util/libxlu_disk_l.h           |   2 +-
tools/libs/util/libxlu_disk_l.l           |   1 +
tools/xl/xl_block.c                       |  11 +
xen/include/public/arch-arm.h             |   7 +
13 files changed, 764 insertions(+), 448 deletions(-)
[RESEND PATCH V5 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")
Posted by Oleksandr Tyshchenko 2 years, 11 months ago
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm.
The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM
support on Arm in the first place. Now, we already have IOREQ support in, so we can resume Virtio
enabling work. You can find previous discussion at [2].

Patch series [3] was reworked and rebased on recent "staging branch"
(972ba1d x86/shadow: streamline shadow_get_page_from_l1e()) and tested on
Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with "updated" virtio-mmio disk backend [4]
running in Driver domain and unmodified Linux Guest running on existing
virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy'
use-cases work properly.

Any feedback/help would be highly appreciated.

[1] 
https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-olekstysh@gmail.com/
[2]
https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02403.html
https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02536.html
[3] https://github.com/otyshchenko1/xen/commits/libxl_virtio
[4] https://github.com/xen-troops/virtio-disk/commits/ioreq_ml3

Julien Grall (1):
  libxl: Introduce basic virtio-mmio support on Arm

Oleksandr Tyshchenko (1):
  libxl: Add support for Virtio disk configuration

 docs/man/xl-disk-configuration.5.pod.in   |  27 +
 tools/include/libxl.h                     |   6 +
 tools/libs/light/libxl_arm.c              | 133 ++++-
 tools/libs/light/libxl_device.c           |  38 +-
 tools/libs/light/libxl_disk.c             |  99 +++-
 tools/libs/light/libxl_types.idl          |   4 +
 tools/libs/light/libxl_types_internal.idl |   1 +
 tools/libs/light/libxl_utils.c            |   2 +
 tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++---------------
 tools/libs/util/libxlu_disk_l.h           |   2 +-
 tools/libs/util/libxlu_disk_l.l           |   1 +
 tools/xl/xl_block.c                       |  11 +
 xen/include/public/arch-arm.h             |   7 +
 13 files changed, 764 insertions(+), 448 deletions(-)

-- 
2.7.4


Re: [RESEND PATCH V5 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")
Posted by Oleksandr 2 years, 9 months ago
Hello all,


Gentle reminder...


On 21.05.21 22:45, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Hello all.
>
> The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm.
> The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM
> support on Arm in the first place. Now, we already have IOREQ support in, so we can resume Virtio
> enabling work. You can find previous discussion at [2].
>
> Patch series [3] was reworked and rebased on recent "staging branch"
> (972ba1d x86/shadow: streamline shadow_get_page_from_l1e()) and tested on
> Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with "updated" virtio-mmio disk backend [4]
> running in Driver domain and unmodified Linux Guest running on existing
> virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy'
> use-cases work properly.
>
> Any feedback/help would be highly appreciated.
>
> [1]
> https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-olekstysh@gmail.com/
> [2]
> https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02403.html
> https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02536.html
> [3] https://github.com/otyshchenko1/xen/commits/libxl_virtio
> [4] https://github.com/xen-troops/virtio-disk/commits/ioreq_ml3
>
> Julien Grall (1):
>    libxl: Introduce basic virtio-mmio support on Arm
>
> Oleksandr Tyshchenko (1):
>    libxl: Add support for Virtio disk configuration
>
>   docs/man/xl-disk-configuration.5.pod.in   |  27 +
>   tools/include/libxl.h                     |   6 +
>   tools/libs/light/libxl_arm.c              | 133 ++++-
>   tools/libs/light/libxl_device.c           |  38 +-
>   tools/libs/light/libxl_disk.c             |  99 +++-
>   tools/libs/light/libxl_types.idl          |   4 +
>   tools/libs/light/libxl_types_internal.idl |   1 +
>   tools/libs/light/libxl_utils.c            |   2 +
>   tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++---------------
>   tools/libs/util/libxlu_disk_l.h           |   2 +-
>   tools/libs/util/libxlu_disk_l.l           |   1 +
>   tools/xl/xl_block.c                       |  11 +
>   xen/include/public/arch-arm.h             |   7 +
>   13 files changed, 764 insertions(+), 448 deletions(-)
>
-- 
Regards,

Oleksandr Tyshchenko


RE: [RESEND PATCH V5 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")
Posted by Wei Chen 2 years, 8 months ago
CC to Jiamei and Henry as they are doing testing

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Oleksandr
> Sent: 2021年7月6日 20:28
> To: xen-devel@lists.xenproject.org
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>; Ian Jackson
> <iwj@xenproject.org>; Wei Liu <wl@xen.org>; Anthony PERARD
> <anthony.perard@citrix.com>; Stefano Stabellini <sstabellini@kernel.org>;
> Julien Grall <julien@xen.org>; Volodymyr Babchuk
> <Volodymyr_Babchuk@epam.com>; Bertrand Marquis <Bertrand.Marquis@arm.com>;
> Wei Chen <Wei.Chen@arm.com>; Kaly Xin <Kaly.Xin@arm.com>; Artem Mygaiev
> <joculator@gmail.com>; Alex Bennée <alex.bennee@linaro.org>
> Subject: Re: [RESEND PATCH V5 0/2] Virtio support for toolstack on Arm
> (Was "IOREQ feature (+ virtio-mmio) on Arm")
> 
> 
> Hello all,
> 
> 
> Gentle reminder...
> 
> 
> On 21.05.21 22:45, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >
> > Hello all.
> >
> > The purpose of this patch series is to add missing virtio-mmio bits to
> Xen toolstack on Arm.
> > The Virtio support for toolstack [1] was postponed as the main target
> was to upstream IOREQ/DM
> > support on Arm in the first place. Now, we already have IOREQ support in,
> so we can resume Virtio
> > enabling work. You can find previous discussion at [2].
> >
> > Patch series [3] was reworked and rebased on recent "staging branch"
> > (972ba1d x86/shadow: streamline shadow_get_page_from_l1e()) and tested
> on
> > Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with "updated" virtio-
> mmio disk backend [4]
> > running in Driver domain and unmodified Linux Guest running on existing
> > virtio-blk driver (frontend). No issues were observed. Guest domain
> 'reboot/destroy'
> > use-cases work properly.
> >
> > Any feedback/help would be highly appreciated.
> >
> > [1]
> > https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-
> olekstysh@gmail.com/
> > https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-
> olekstysh@gmail.com/
> > [2]
> > https://lists.xenproject.org/archives/html/xen-devel/2021-
> 01/msg02403.html
> > https://lists.xenproject.org/archives/html/xen-devel/2021-
> 01/msg02536.html
> > [3] https://github.com/otyshchenko1/xen/commits/libxl_virtio
> > [4] https://github.com/xen-troops/virtio-disk/commits/ioreq_ml3
> >
> > Julien Grall (1):
> >    libxl: Introduce basic virtio-mmio support on Arm
> >
> > Oleksandr Tyshchenko (1):
> >    libxl: Add support for Virtio disk configuration
> >
> >   docs/man/xl-disk-configuration.5.pod.in   |  27 +
> >   tools/include/libxl.h                     |   6 +
> >   tools/libs/light/libxl_arm.c              | 133 ++++-
> >   tools/libs/light/libxl_device.c           |  38 +-
> >   tools/libs/light/libxl_disk.c             |  99 +++-
> >   tools/libs/light/libxl_types.idl          |   4 +
> >   tools/libs/light/libxl_types_internal.idl |   1 +
> >   tools/libs/light/libxl_utils.c            |   2 +
> >   tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++-------
> --------
> >   tools/libs/util/libxlu_disk_l.h           |   2 +-
> >   tools/libs/util/libxlu_disk_l.l           |   1 +
> >   tools/xl/xl_block.c                       |  11 +
> >   xen/include/public/arch-arm.h             |   7 +
> >   13 files changed, 764 insertions(+), 448 deletions(-)
> >
> --
> Regards,
> 
> Oleksandr Tyshchenko
>