... to be in line with Misra rule 8.2 requirements.

Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch controlled")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The offending patch had been pending for far longer than we care about
Misra, and hence at the time of writing I didn't pay attention. And then
I never looked again. I'm sorry.

--- a/xen/arch/x86/include/asm/page.h
+++ b/xen/arch/x86/include/asm/page.h
@@ -227,8 +227,8 @@ void copy_page_sse2(void *to, const void
 #define copy_page(_t, _f)   copy_page_sse2(_t, _f)
 
 #ifdef CONFIG_DEBUG
-void scrub_page_hot(void *);
-void scrub_page_cold(void *);
+void scrub_page_hot(void *ptr);
+void scrub_page_cold(void *ptr);
 #endif
 
 /* Convert between Xen-heap virtual addresses and machine addresses. */

On 2025-07-23 16:37, Jan Beulich wrote:
> ... to be in line with Misra rule 8.2 requirements.
> 
> Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch 
> controlled")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

> ---
> The offending patch had been pending for far longer than we care about
> Misra, and hence at the time of writing I didn't pay attention. And 
> then
> I never looked again. I'm sorry.
> 

Ah, sorry, I didn't notice your patch, I just sent basically an 
identical one, feel free to disregard it.

> --- a/xen/arch/x86/include/asm/page.h
> +++ b/xen/arch/x86/include/asm/page.h
> @@ -227,8 +227,8 @@ void copy_page_sse2(void *to, const void
>  #define copy_page(_t, _f)   copy_page_sse2(_t, _f)
> 
>  #ifdef CONFIG_DEBUG
> -void scrub_page_hot(void *);
> -void scrub_page_cold(void *);
> +void scrub_page_hot(void *ptr);
> +void scrub_page_cold(void *ptr);
>  #endif
> 
>  /* Convert between Xen-heap virtual addresses and machine addresses. 
> */

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253

On 23.07.2025 16:47, Nicola Vetrini wrote:
> On 2025-07-23 16:37, Jan Beulich wrote:
>> ... to be in line with Misra rule 8.2 requirements.
>>
>> Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch 
>> controlled")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

Thanks.

>> ---
>> The offending patch had been pending for far longer than we care about
>> Misra, and hence at the time of writing I didn't pay attention. And 
>> then
>> I never looked again. I'm sorry.
> 
> Ah, sorry, I didn't notice your patch, I just sent basically an 
> identical one, feel free to disregard it.

I've seen it, but indeed I prefer to put in mine. "pg" is what we more
commonly use for struct page_info * type variables / parameters.

Jan