drivers/gpu/drm/xen/xen_drm_front.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fix a static code checker warning:
drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
warn: passing zero to 'PTR_ERR'
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 4be49c1..3741420 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
obj = xen_drm_front_gem_create(dev, args->size);
if (IS_ERR_OR_NULL(obj)) {
- ret = PTR_ERR(obj);
+ ret = PTR_ERR_OR_ZERO(obj);
goto fail;
}
--
1.9.1
On 3/30/20 12:59, Ding Xiang wrote: > Fix a static code checker warning: > drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() > warn: passing zero to 'PTR_ERR' > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > --- > drivers/gpu/drm/xen/xen_drm_front.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c > index 4be49c1..3741420 100644 > --- a/drivers/gpu/drm/xen/xen_drm_front.c > +++ b/drivers/gpu/drm/xen/xen_drm_front.c > @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, > > obj = xen_drm_front_gem_create(dev, args->size); > if (IS_ERR_OR_NULL(obj)) { > - ret = PTR_ERR(obj); > + ret = PTR_ERR_OR_ZERO(obj); > goto fail; > } >
On Tue, Mar 31, 2020 at 05:50:10PM +0300, Oleksandr Andrushchenko wrote: > On 3/30/20 12:59, Ding Xiang wrote: > > Fix a static code checker warning: > > drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() > > warn: passing zero to 'PTR_ERR' > > > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> merged to drm-misc-next-fixese. -Daniel > > --- > > drivers/gpu/drm/xen/xen_drm_front.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c > > index 4be49c1..3741420 100644 > > --- a/drivers/gpu/drm/xen/xen_drm_front.c > > +++ b/drivers/gpu/drm/xen/xen_drm_front.c > > @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, > > obj = xen_drm_front_gem_create(dev, args->size); > > if (IS_ERR_OR_NULL(obj)) { > > - ret = PTR_ERR(obj); > > + ret = PTR_ERR_OR_ZERO(obj); > > goto fail; > > } -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
© 2016 - 2024 Red Hat, Inc.