From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

The Arm realization should have been removed in the following commit
as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables

So, remove unused function completely.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 xen/drivers/passthrough/arm/iommu.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
index 76e1152..db3b07a 100644
--- a/xen/drivers/passthrough/arm/iommu.c
+++ b/xen/drivers/passthrough/arm/iommu.c
@@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
 {
 }
 
-int arch_iommu_populate_page_table(struct domain *d)
-{
-    /* The IOMMU shares the p2m with the CPU */
-    return -ENOSYS;
-}
-
 void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
 {
 }
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

> -----Original Message-----
> From: Oleksandr Tyshchenko <olekstysh@gmail.com>
> Sent: 30 September 2019 11:35
> To: xen-devel@lists.xenproject.org
> Cc: julien.grall@arm.com; sstabellini@kernel.org; volodymyr_babchuk@epam.com; jgross@suse.com; Paul
> Durrant <Paul.Durrant@citrix.com>; Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Subject: [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely
> 
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
> 
> So, remove unused function completely.

Good catch.

Reviewed-by: Paul Durrant <paul@xen.org>

> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  xen/drivers/passthrough/arm/iommu.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
> index 76e1152..db3b07a 100644
> --- a/xen/drivers/passthrough/arm/iommu.c
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
>  {
>  }
> 
> -int arch_iommu_populate_page_table(struct domain *d)
> -{
> -    /* The IOMMU shares the p2m with the CPU */
> -    return -ENOSYS;
> -}
> -
>  void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
>  {
>  }
> --
> 2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

On 30.09.19 12:34, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
> 
> So, remove unused function completely.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Hi


On 30.09.19 13:44, Jürgen Groß wrote:
> On 30.09.19 12:34, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> The Arm realization should have been removed in the following commit
>> as redundant:
>> f89f555 remove late (on-demand) construction of IOMMU page tables
>>
>> So, remove unused function completely.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Release-acked-by: Juergen Gross <jgross@suse.com>


Thank you all.


-- 
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Hi, all


Gentle reminder...

-- 
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

On 08/10/2019 18:21, Oleksandr wrote:
> 
> Hi, all

Hi,

> 
> Gentle reminder...

Sorry this fell through the cracks. I have now committed it.

Cheers,

> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Hi Oleksandr,

On 30/09/2019 11:34, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
> 
> So, remove unused function completely.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel