arm/traps.c: Adjust HPFAR_EL2 representation

[Xen-devel] [PATCH] arm/traps.c: Adjust HPFAR_EL2 representation

Posted by Andrii Anisov 4 years, 7 months ago

From: Andrii Anisov <andrii_anisov@epam.com>

In the commit af156ff0859c8d362a5706640614c9d10f62adf2, it
was left unattended HPFAR_EL2 register output. Now it is printed
with 1608 digits, what is way too wide even for the biggest
monitors. So cleanup excessive paddings.

Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
---
 xen/arch/arm/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index f013297..addccb9 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -938,7 +938,7 @@ static void _show_registers(const struct cpu_user_regs *regs,
     printk(" TTBR0_EL2: %016"PRIx64"\n", READ_SYSREG64(TTBR0_EL2));
     printk("\n");
     printk("   ESR_EL2: %08"PRIx32"\n", regs->hsr);
-    printk(" HPFAR_EL2: %016"PRIregister"\n", READ_SYSREG(HPFAR_EL2));
+    printk(" HPFAR_EL2: %"PRIregister"\n", READ_SYSREG(HPFAR_EL2));
 
 #ifdef CONFIG_ARM_32
     printk("     HDFAR: %08"PRIx32"\n", READ_CP32(HDFAR));
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] arm/traps.c: Adjust HPFAR_EL2 representation

Posted by Julien Grall 4 years, 7 months ago

Hi,

On 27/08/2019 18:33, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@epam.com>
> 
> In the commit af156ff0859c8d362a5706640614c9d10f62adf2, it
> was left unattended HPFAR_EL2 register output. Now it is printed
> with 1608 digits, what is way too wide even for the biggest
> monitors. So cleanup excessive paddings.

A more complete patch (fix another place) has already been sent on the 
mailing list (see [1]). It is waiting on Stefano's ack at the moment...

Cheers,

[1] 
https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01439.html


-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] arm/traps.c: Adjust HPFAR_EL2 representation

Posted by Stefano Stabellini 4 years, 7 months ago

On Tue, 27 Aug 2019, Julien Grall wrote:
> Hi,
> 
> On 27/08/2019 18:33, Andrii Anisov wrote:
> > From: Andrii Anisov <andrii_anisov@epam.com>
> > 
> > In the commit af156ff0859c8d362a5706640614c9d10f62adf2, it
> > was left unattended HPFAR_EL2 register output. Now it is printed
> > with 1608 digits, what is way too wide even for the biggest
> > monitors. So cleanup excessive paddings.
> 
> A more complete patch (fix another place) has already been sent on the 
> mailing list (see [1]). It is waiting on Stefano's ack at the moment...
> 
> Cheers,
> 
> [1] 
> https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01439.html

The patch is in staging now.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] arm/traps.c: Adjust HPFAR_EL2 representation

Posted by Andrii Anisov 4 years, 7 months ago


On 27.08.19 20:18, Julien Grall wrote:

> A more complete patch (fix another place) has already been sent on the
> mailing list (see [1]). It is waiting on Stefano's ack at the moment...
> 
> Cheers,
> 
> [1]
> https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg01439.html

Ah, yes. Missed it.

-- 
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel