tools: ipxe: update for fixing build with GCC9

[Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9

Posted by Dario Faggioli 4 years, 9 months ago

Building with GCC9 (on openSUSE Tubmleweed) generates a lot of errors of
the "taking address of packed member of ... may result in an unaligned
pointer value" kind.

Updating to upstream commit 1dd56dbd11082 ("[build] Workaround compilation
error with gcc 9.1") seems to fix the problem.

For more info, see:

https://git.ipxe.org/ipxe.git/commit/1dd56dbd11082fb622c2ed21cfaced4f47d798a6

Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
Cc: Wei Liu <wl@xen.org>
---
Hey, Wei,

I have never played much with ipxe, so I can't be 100% sure that this is
the best idea, and what could be the problems.

I just thought I'll mention the issue to you, in the form of a patch, in
an attempt to help as much as possible.

Regards
---
 tools/firmware/etherboot/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index fd8dfdf5a7..0de30599bf 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -10,7 +10,7 @@ else
 IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
-IPXE_GIT_TAG := d2063b7693e0e35db97b2264aa987eb6341ae779
+IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6
 
 IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9

Posted by Wei Liu 4 years, 9 months ago

On Sat, Jul 27, 2019 at 12:13:49AM +0200, Dario Faggioli wrote:
> Building with GCC9 (on openSUSE Tubmleweed) generates a lot of errors of
> the "taking address of packed member of ... may result in an unaligned
> pointer value" kind.
> 
> Updating to upstream commit 1dd56dbd11082 ("[build] Workaround compilation
> error with gcc 9.1") seems to fix the problem.
> 
> For more info, see:
> 
> https://git.ipxe.org/ipxe.git/commit/1dd56dbd11082fb622c2ed21cfaced4f47d798a6
> 
> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> ---
> Cc: Wei Liu <wl@xen.org>
> ---
> Hey, Wei,
> 
> I have never played much with ipxe, so I can't be 100% sure that this is
> the best idea, and what could be the problems.
> 

Yes this is what we normally do.

Acked-by: Wei Liu <wl@xen.org>

Further improvement would be to separate ipxe from the build and track
upstream in osstest since tools is now able to load an IPXE binary, but
this will do.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9

Posted by Ian Jackson 4 years, 8 months ago

Wei Liu writes ("Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9"):
> On Sat, Jul 27, 2019 at 12:13:49AM +0200, Dario Faggioli wrote:
> > Building with GCC9 (on openSUSE Tubmleweed) generates a lot of errors of
> > the "taking address of packed member of ... may result in an unaligned
> > pointer value" kind.
> > 
> > Updating to upstream commit 1dd56dbd11082 ("[build] Workaround compilation
> > error with gcc 9.1") seems to fix the problem.
> > 
> > For more info, see:
...
> Yes this is what we normally do.
> 
> Acked-by: Wei Liu <wl@xen.org>

Thanks all.  Should this be backported anywhere ?  I'm inclined to say
"no" because someone who wants this can easily change it themselves,
and we don't want to disturb stable users with an ipxe version update.

But I'm open to opinions.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9

Posted by Wei Liu 4 years, 8 months ago

On Mon, 5 Aug 2019 at 15:30, Ian Jackson <ian.jackson@citrix.com> wrote:
>
> Wei Liu writes ("Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9"):
> > On Sat, Jul 27, 2019 at 12:13:49AM +0200, Dario Faggioli wrote:
> > > Building with GCC9 (on openSUSE Tubmleweed) generates a lot of errors of
> > > the "taking address of packed member of ... may result in an unaligned
> > > pointer value" kind.
> > >
> > > Updating to upstream commit 1dd56dbd11082 ("[build] Workaround compilation
> > > error with gcc 9.1") seems to fix the problem.
> > >
> > > For more info, see:
> ...
> > Yes this is what we normally do.
> >
> > Acked-by: Wei Liu <wl@xen.org>
>
> Thanks all.  Should this be backported anywhere ?  I'm inclined to say
> "no" because someone who wants this can easily change it themselves,
> and we don't want to disturb stable users with an ipxe version update.
>

Agreed. I don't think this needs to be backported.

Wei.

> But I'm open to opinions.
>
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel