x86/PV: correct post-preemption progress recording in iommu_memory_setup()

[PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

Posted by Jan Beulich 1 year, 8 months ago

Coverity validly points out that the mfn_add() as used was dead code.

Coverity ID: 1507475
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -130,7 +130,7 @@ static void __init iommu_memory_setup(st
                             IOMMUF_readable | IOMMUF_writable | IOMMUF_preempt,
                             flush_flags)) > 0 )
     {
-        mfn_add(mfn, rc);
+        mfn = mfn_add(mfn, rc);
         nr -= rc;
         /* See comment below. */
         for ( ; rc--; ++page )

Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

Posted by Andrew Cooper 1 year, 8 months ago

On 27/07/2022 11:41, Jan Beulich wrote:
> Coverity validly points out that the mfn_add() as used was dead code.
>
> Coverity ID: 1507475
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

Posted by Andrew Cooper 1 year, 8 months ago

On 27/07/2022 11:44, Andrew Cooper wrote:
> On 27/07/2022 11:41, Jan Beulich wrote:
>> Coverity validly points out that the mfn_add() as used was dead code.
>>
>> Coverity ID: 1507475
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Although on second thoughts, this needs a fixes c1e1564c8995d tag too.

~Andrew

Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()

Posted by Jan Beulich 1 year, 8 months ago

On 27.07.2022 12:46, Andrew Cooper wrote:
> On 27/07/2022 11:44, Andrew Cooper wrote:
>> On 27/07/2022 11:41, Jan Beulich wrote:
>>> Coverity validly points out that the mfn_add() as used was dead code.
>>>
>>> Coverity ID: 1507475
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Although on second thoughts, this needs a fixes c1e1564c8995d tag too.

Oh, of course.

Jan