[v1] xen/ppc: Fix tooling FTBFS due to missing definitions in public header

[PATCH] xen/ppc: Fix tooling FTBFS due to missing definitions in public header

Posted by Timothy Pearson 20 hours ago

int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler
is in use.
---
 xen/include/public/arch-ppc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/arch-ppc.h b/xen/include/public/arch-ppc.h
index 4ca453a284..264e20b89e 100644
--- a/xen/include/public/arch-ppc.h
+++ b/xen/include/public/arch-ppc.h
@@ -11,7 +11,7 @@
 #ifndef __XEN_PUBLIC_ARCH_PPC_H__
 #define __XEN_PUBLIC_ARCH_PPC_H__
 
-#if defined(__XEN__) || defined(__XEN_TOOLS__)
+#if defined(__XEN__) || defined(__XEN_TOOLS__) || defined(__GNUC__)
 #define  int64_aligned_t  int64_t __attribute__((__aligned__(8)))
 #define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))
 #endif
-- 
2.39.5

Re: [PATCH] xen/ppc: Fix tooling FTBFS due to missing definitions in public header

Posted by Jan Beulich 11 hours ago

On 29.10.2025 00:28, Timothy Pearson wrote:
> int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler
> is in use.
> ---
>  xen/include/public/arch-ppc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jan Beulich <jbeulich@suse.com>

However, first of all this needs your own S-o-b.

Jan

> diff --git a/xen/include/public/arch-ppc.h b/xen/include/public/arch-ppc.h
> index 4ca453a284..264e20b89e 100644
> --- a/xen/include/public/arch-ppc.h
> +++ b/xen/include/public/arch-ppc.h
> @@ -11,7 +11,7 @@
>  #ifndef __XEN_PUBLIC_ARCH_PPC_H__
>  #define __XEN_PUBLIC_ARCH_PPC_H__
>  
> -#if defined(__XEN__) || defined(__XEN_TOOLS__)
> +#if defined(__XEN__) || defined(__XEN_TOOLS__) || defined(__GNUC__)
>  #define  int64_aligned_t  int64_t __attribute__((__aligned__(8)))
>  #define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))
>  #endif

Re: [PATCH] xen/ppc: Fix tooling FTBFS due to missing definitions in public header

Posted by Timothy Pearson 3 hours ago


----- Original Message -----
> From: "Jan Beulich" <jbeulich@suse.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "xen-devel" <xen-devel@lists.xenproject.org>
> Sent: Wednesday, October 29, 2025 2:59:11 AM
> Subject: Re: [PATCH] xen/ppc: Fix tooling FTBFS due to missing definitions in public header

> On 29.10.2025 00:28, Timothy Pearson wrote:
>> int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler
>> is in use.
>> ---
>>  xen/include/public/arch-ppc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> However, first of all this needs your own S-o-b.
> 
> Jan

My apologies for that.  Was getting a new development box set up for Xen and somehow missed that on the first two patches.