int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler
is in use.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
---
xen/include/public/arch-ppc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/arch-ppc.h b/xen/include/public/arch-ppc.h
index 4ca453a284..264e20b89e 100644
--- a/xen/include/public/arch-ppc.h
+++ b/xen/include/public/arch-ppc.h
@@ -11,7 +11,7 @@
#ifndef __XEN_PUBLIC_ARCH_PPC_H__
#define __XEN_PUBLIC_ARCH_PPC_H__
-#if defined(__XEN__) || defined(__XEN_TOOLS__)
+#if defined(__XEN__) || defined(__XEN_TOOLS__) || defined(__GNUC__)
#define int64_aligned_t int64_t __attribute__((__aligned__(8)))
#define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))
#endif
--
2.39.5
On 29.10.2025 17:23, Timothy Pearson wrote: > int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler > is in use. > > Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> Thanks. However, you've lost my R-b, and the Cc list was again entirely empty. Jan
----- Original Message ----- > From: "Jan Beulich" <jbeulich@suse.com> > To: "Timothy Pearson" <tpearson@raptorengineering.com> > Cc: "xen-devel" <xen-devel@lists.xenproject.org>, "Andrew Cooper" <andrew.cooper3@citrix.com>, "Julien Grall" > <julien@xen.org>, "Stefano Stabellini" <sstabellini@kernel.org>, "Anthony PERARD" <anthony.perard@vates.tech>, "Michal > Orzel" <michal.orzel@amd.com>, "Roger Pau Monné" <roger.pau@citrix.com> > Sent: Thursday, October 30, 2025 2:43:00 AM > Subject: Re: [PATCH v2] xen/ppc: Fix tooling FTBFS due to missing definitions in public header > On 29.10.2025 17:23, Timothy Pearson wrote: >> int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler >> is in use. >> >> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> > > Thanks. However, you've lost my R-b, and the Cc list was again entirely empty. > > Jan Apologies again. I had thought for a trivial patch the CC was not required, will keep that in mind in the future. Thanks!
On 30.10.2025 16:10, Timothy Pearson wrote: > ----- Original Message ----- >> From: "Jan Beulich" <jbeulich@suse.com> >> To: "Timothy Pearson" <tpearson@raptorengineering.com> > >> On 29.10.2025 17:23, Timothy Pearson wrote: >>> int64_aligned_t and uint64_aligned_t need to be exposed when the GNU C compiler >>> is in use. >>> >>> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> >> >> Thanks. However, you've lost my R-b, and the Cc list was again entirely empty. > > Apologies again. I had thought for a trivial patch the CC was not required, will keep that in mind in the future. Just to clarify: However trivial a patch, it needs to be acked by a maintainer. Hence they will want Cc-ing (not everyone's subscribed to the list, and not everyone may be following each and every patch that's flowing in). Jan
© 2016 - 2025 Red Hat, Inc.