x86/PVH: permit more physdevop-s to be used by Dom0

[PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0

Posted by Jan Beulich 2 years, 4 months ago

Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
running in. Permit further PCI related ones (only their modern forms).
Also include the USB2 debug port operation at this occasion. While
largely relevant for the latter, drop the has_vpci() part of the
conditional as redundant with is_hardware_domain(): There's no PVH Dom0
without vPCI.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v5: For now leave out PHYSDEVOP_{prepare,release}_msix and
    PHYSDEVOP_restore_msi_ext. Drop has_vpci() part of the conditional.
v3: New.

--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -94,7 +94,10 @@ static long hvm_physdev_op(int cmd, XEN_
         break;
 
     case PHYSDEVOP_pci_mmcfg_reserved:
-        if ( !has_vpci(currd) || !is_hardware_domain(currd) )
+    case PHYSDEVOP_pci_device_add:
+    case PHYSDEVOP_pci_device_remove:
+    case PHYSDEVOP_dbgp_op:
+        if ( !is_hardware_domain(currd) )
             return -ENOSYS;
         break;

Re: [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0

Posted by Roger Pau Monné 2 years, 4 months ago

On Fri, Dec 03, 2021 at 11:28:39AM +0100, Jan Beulich wrote:
> Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
> running in. Permit further PCI related ones (only their modern forms).
> Also include the USB2 debug port operation at this occasion. While
> largely relevant for the latter, drop the has_vpci() part of the
> conditional as redundant with is_hardware_domain(): There's no PVH Dom0
> without vPCI.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.