x86emul: fix SIMD test overriding of VBROADCASTS{S,D}

[PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}

Jan Beulich posted 1 patch 2 years, 2 months ago

Download mbox

Test gitlab-ci passed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/0519c820-f1ee-1b37-f1be-90bd1daf37ed@suse.com

Expand all Fold all

[PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}

Posted by Jan Beulich 2 years, 2 months ago

Despite their suffixes these aren't scalar instructions, and hence the
128- and 256-bit EVEX forms may not be used without AVX512VL. Gcc11 ends
up generating such instances for simd-sg.c.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/x86_emulator/simd.h
+++ b/tools/tests/x86_emulator/simd.h
@@ -250,7 +250,9 @@ asm ( ".macro override insn    \n\t"
 # define OVR_INT(n) OVR_BW(n); OVR_DQ(n)
 
 OVR_INT(broadcast);
+# ifdef __AVX512VL__
 OVR_SFP(broadcast);
+# endif
 OVR_SFP(comi);
 OVR_VFP(cvtdq2);
 OVR_INT(abs);

Re: [PATCH] x86emul: fix SIMD test overriding of VBROADCASTS{S,D}

Posted by Andrew Cooper 2 years, 2 months ago

On 11/02/2022 11:11, Jan Beulich wrote:
> Despite their suffixes these aren't scalar instructions, and hence the
> 128- and 256-bit EVEX forms may not be used without AVX512VL. Gcc11 ends
> up generating such instances for simd-sg.c.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>