xen/common/sched/private.h | 99 ++++++++++++++++++++------------------ 1 file changed, 53 insertions(+), 46 deletions(-)
Add missing parameter names. No functional change.
Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
Changes in v2:
- added parameter names in accordance with schedulers in xen/common/sched/*;
- improved comment format.
---
xen/common/sched/private.h | 99 ++++++++++++++++++++------------------
1 file changed, 53 insertions(+), 46 deletions(-)
diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h
index c516976c37..79e3f56c5a 100644
--- a/xen/common/sched/private.h
+++ b/xen/common/sched/private.h
@@ -37,10 +37,11 @@ enum sched_gran {
* locks. The generic schedule init code will point each schedule lock
* pointer to the schedule lock; if the scheduler wants to remap them,
* it can simply modify the schedule locks.
- *
+ *
* For cache betterness, keep the actual lock in the same cache area
* as the rest of the struct. Just have the scheduler point to the
- * one it wants (This may be the one right in front of it).*/
+ * one it wants (This may be the one right in front of it).
+ */
struct sched_resource {
struct scheduler *scheduler;
struct cpupool *cpupool;
@@ -280,59 +281,65 @@ struct scheduler {
int (*global_init) (void);
- int (*init) (struct scheduler *);
- void (*deinit) (struct scheduler *);
+ int (*init) (struct scheduler *ops);
+ void (*deinit) (struct scheduler *ops);
+
+ void (*free_udata) (const struct scheduler *ops, void *priv);
+ void * (*alloc_udata) (const struct scheduler *ops,
+ struct sched_unit *unit, void *dd);
- void (*free_udata) (const struct scheduler *, void *);
- void * (*alloc_udata) (const struct scheduler *,
- struct sched_unit *, void *);
- void (*free_pdata) (const struct scheduler *, void *, int);
- void * (*alloc_pdata) (const struct scheduler *, int);
- void (*deinit_pdata) (const struct scheduler *, void *, int);
+ void (*free_pdata) (const struct scheduler *ops,
+ void *pcpu, int cpu);
+ void * (*alloc_pdata) (const struct scheduler *ops, int cpu);
+ void (*deinit_pdata) (const struct scheduler *ops,
+ void *pcpu, int cpu);
/* Returns ERR_PTR(-err) for error, NULL for 'nothing needed'. */
- void * (*alloc_domdata) (const struct scheduler *, struct domain *);
+ void * (*alloc_domdata) (const struct scheduler *ops,
+ struct domain *dom);
/* Idempotent. */
- void (*free_domdata) (const struct scheduler *, void *);
+ void (*free_domdata) (const struct scheduler *ops, void *data);
- spinlock_t * (*switch_sched) (struct scheduler *, unsigned int,
- void *, void *);
+ spinlock_t * (*switch_sched) (struct scheduler *new_ops, unsigned int cpu,
+ void *pdata, void *vdata);
/* Activate / deactivate units in a cpu pool */
- void (*insert_unit) (const struct scheduler *,
- struct sched_unit *);
- void (*remove_unit) (const struct scheduler *,
- struct sched_unit *);
-
- void (*sleep) (const struct scheduler *,
- struct sched_unit *);
- void (*wake) (const struct scheduler *,
- struct sched_unit *);
- void (*yield) (const struct scheduler *,
- struct sched_unit *);
- void (*context_saved) (const struct scheduler *,
- struct sched_unit *);
-
- void (*do_schedule) (const struct scheduler *,
- struct sched_unit *, s_time_t,
+ void (*insert_unit) (const struct scheduler *ops,
+ struct sched_unit *unit);
+ void (*remove_unit) (const struct scheduler *ops,
+ struct sched_unit *unit);
+
+ void (*sleep) (const struct scheduler *ops,
+ struct sched_unit *unit);
+ void (*wake) (const struct scheduler *ops,
+ struct sched_unit *unit);
+ void (*yield) (const struct scheduler *ops,
+ struct sched_unit *unit);
+ void (*context_saved) (const struct scheduler *ops,
+ struct sched_unit *unit);
+
+ void (*do_schedule) (const struct scheduler *ops,
+ struct sched_unit *currunit, s_time_t now,
bool tasklet_work_scheduled);
- struct sched_resource *(*pick_resource)(const struct scheduler *,
- const struct sched_unit *);
- void (*migrate) (const struct scheduler *,
- struct sched_unit *, unsigned int);
- int (*adjust) (const struct scheduler *, struct domain *,
- struct xen_domctl_scheduler_op *);
- void (*adjust_affinity)(const struct scheduler *,
- struct sched_unit *,
- const struct cpumask *,
- const struct cpumask *);
- int (*adjust_global) (const struct scheduler *,
- struct xen_sysctl_scheduler_op *);
- void (*dump_settings) (const struct scheduler *);
- void (*dump_cpu_state) (const struct scheduler *, int);
- void (*move_timers) (const struct scheduler *,
- struct sched_resource *);
+ struct sched_resource *(*pick_resource)(const struct scheduler *ops,
+ const struct sched_unit *unit);
+ void (*migrate) (const struct scheduler *ops,
+ struct sched_unit *unit,
+ unsigned int new_cpu);
+ int (*adjust) (const struct scheduler *ops,
+ struct domain *d,
+ struct xen_domctl_scheduler_op *op);
+ void (*adjust_affinity)(const struct scheduler *ops,
+ struct sched_unit *unit,
+ const struct cpumask *hard,
+ const struct cpumask *soft);
+ int (*adjust_global) (const struct scheduler *ops,
+ struct xen_sysctl_scheduler_op *sc);
+ void (*dump_settings) (const struct scheduler *ops);
+ void (*dump_cpu_state) (const struct scheduler *ops, int cpu);
+ void (*move_timers) (const struct scheduler *ops,
+ struct sched_resource *sr);
};
static inline int sched_init(struct scheduler *s)
--
2.34.1On Mon, Oct 9, 2023 at 3:23 PM Federico Serafini <federico.serafini@bugseng.com> wrote: > > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Acked-by: George Dunlap <george.dunlap@cloud.com> Sorry for the delay.
On Mon, 9 Oct 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Hi, > On Oct 10, 2023, at 09:25, Stefano Stabellini <sstabellini@kernel.org> wrote: > > On Mon, 9 Oct 2023, Federico Serafini wrote: >> Add missing parameter names. No functional change. >> >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Release-acked-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry >
On 10/10/23 03:26, Henry Wang wrote: > Hi, > >> On Oct 10, 2023, at 09:25, Stefano Stabellini <sstabellini@kernel.org> wrote: >> >> On Mon, 9 Oct 2023, Federico Serafini wrote: >>> Add missing parameter names. No functional change. >>> >>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> >> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > Release-acked-by: Henry Wang <Henry.Wang@arm.com> Any chance to get an ack? -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com)
© 2016 - 2024 Red Hat, Inc.