xvmalloc: please Misra C:2012 Rule 8.2

[PATCH] xvmalloc: please Misra C:2012 Rule 8.2

Posted by Jan Beulich 1 year, 5 months ago

The cloning from xmalloc.h happened long before Misra work started in
earnest, leading to the missing parameter name having been overlooked
later on.

Fixes: 9102fcd9579f ("mm: introduce xvmalloc() et al and use for grant table allocations")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/xvmalloc.h
+++ b/xen/include/xen/xvmalloc.h
@@ -41,7 +41,7 @@
                              __alignof__(typeof(*(ptr)))))
 
 /* Free any of the above. */
-void xvfree(void *);
+void xvfree(void *va);
 
 /* Free an allocation, and zero the pointer to it. */
 #define XVFREE(p) do { \

Re: [PATCH] xvmalloc: please Misra C:2012 Rule 8.2

Posted by Andrew Cooper 1 year, 5 months ago

On 14/08/2024 9:06 am, Jan Beulich wrote:
> The cloning from xmalloc.h happened long before Misra work started in
> earnest, leading to the missing parameter name having been overlooked
> later on.
>
> Fixes: 9102fcd9579f ("mm: introduce xvmalloc() et al and use for grant table allocations")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Re: [PATCH] xvmalloc: please Misra C:2012 Rule 8.2

Posted by Michal Orzel 1 year, 5 months ago


On 14/08/2024 10:06, Jan Beulich wrote:
> 
> 
> The cloning from xmalloc.h happened long before Misra work started in
> earnest, leading to the missing parameter name having been overlooked
> later on.
> 
> Fixes: 9102fcd9579f ("mm: introduce xvmalloc() et al and use for grant table allocations")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Michal Orzel <michal.orzel@amd.com>

~Michal