xen/arm/IRQ: uniform irq_set_affinity() with x86 version

[XEN PATCH] xen/arm/IRQ: uniform irq_set_affinity() with x86 version

Posted by Federico Serafini 2 years, 6 months ago

Change parameter name of irq_set_affinity() to uniform the function
prototype with the one used by x86.

No functional changes.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/arch/arm/include/asm/irq.h | 2 +-
 xen/arch/arm/irq.c             | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/include/asm/irq.h b/xen/arch/arm/include/asm/irq.h
index 105b33b37d..c8044b0371 100644
--- a/xen/arch/arm/include/asm/irq.h
+++ b/xen/arch/arm/include/asm/irq.h
@@ -91,7 +91,7 @@ int platform_get_irq(const struct dt_device_node *device, int index);
 
 int platform_get_irq_byname(const struct dt_device_node *np, const char *name);
 
-void irq_set_affinity(struct irq_desc *desc, const cpumask_t *cpu_mask);
+void irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask);
 
 /*
  * Use this helper in places that need to know whether the IRQ type is
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index 054bb281d8..09648db17a 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -175,10 +175,10 @@ static inline struct domain *irq_get_domain(struct irq_desc *desc)
     return irq_get_guest_info(desc)->d;
 }
 
-void irq_set_affinity(struct irq_desc *desc, const cpumask_t *cpu_mask)
+void irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask)
 {
     if ( desc != NULL )
-        desc->handler->set_affinity(desc, cpu_mask);
+        desc->handler->set_affinity(desc, mask);
 }
 
 int request_irq(unsigned int irq, unsigned int irqflags,
-- 
2.34.1

Re: [XEN PATCH] xen/arm/IRQ: uniform irq_set_affinity() with x86 version

Posted by Stefano Stabellini 2 years, 6 months ago

On Mon, 31 Jul 2023, Federico Serafini wrote:
> Change parameter name of irq_set_affinity() to uniform the function
> prototype with the one used by x86.
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/arch/arm/include/asm/irq.h | 2 +-
>  xen/arch/arm/irq.c             | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/irq.h b/xen/arch/arm/include/asm/irq.h
> index 105b33b37d..c8044b0371 100644
> --- a/xen/arch/arm/include/asm/irq.h
> +++ b/xen/arch/arm/include/asm/irq.h
> @@ -91,7 +91,7 @@ int platform_get_irq(const struct dt_device_node *device, int index);
>  
>  int platform_get_irq_byname(const struct dt_device_node *np, const char *name);
>  
> -void irq_set_affinity(struct irq_desc *desc, const cpumask_t *cpu_mask);
> +void irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask);
>  
>  /*
>   * Use this helper in places that need to know whether the IRQ type is
> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> index 054bb281d8..09648db17a 100644
> --- a/xen/arch/arm/irq.c
> +++ b/xen/arch/arm/irq.c
> @@ -175,10 +175,10 @@ static inline struct domain *irq_get_domain(struct irq_desc *desc)
>      return irq_get_guest_info(desc)->d;
>  }
>  
> -void irq_set_affinity(struct irq_desc *desc, const cpumask_t *cpu_mask)
> +void irq_set_affinity(struct irq_desc *desc, const cpumask_t *mask)
>  {
>      if ( desc != NULL )
> -        desc->handler->set_affinity(desc, cpu_mask);
> +        desc->handler->set_affinity(desc, mask);
>  }
>  
>  int request_irq(unsigned int irq, unsigned int irqflags,
> -- 
> 2.34.1
>