[Kimchi-devel] [PATCH] [WoK] Removing sessionStorage call in wok.main.js

dhbarboza82@gmail.com posted 1 patch 4 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/kimchi-wok tags/patchew/20170323123451.28127-1-dhbarboza82@gmail.com
ui/js/src/wok.main.js | 1 -
1 file changed, 1 deletion(-)

[Kimchi-devel] [PATCH] [WoK] Removing sessionStorage call in wok.main.js

Posted by dhbarboza82@gmail.com 4 years, 1 month ago
From: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>

sessionStorage was being used in early versions of the websocket
notifications implementation to avoid opening multiple connections,
before the current single permanent connection approach was
implemented. If the 'wokNotificationWebSocket' key existed in the
sessionStorage, we skipped the opening of a new websocket.

This patch removes the sessionStorage usage because it accomplishes
nothing in current code. No verification is made using the created
'wokNotificationWebSocket' session key in the code.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
---
 ui/js/src/wok.main.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/js/src/wok.main.js b/ui/js/src/wok.main.js
index 26dc723..411b05e 100644
--- a/ui/js/src/wok.main.js
+++ b/ui/js/src/wok.main.js
@@ -69,7 +69,6 @@ wok.startNotificationWebSocket = function () {
         }
     };
 
-    sessionStorage.setItem('wokNotificationWebSocket', 'true');
     var heartbeat = setInterval(function() {
         wok.notificationsWebSocket.send(window.btoa('heartbeat'));
     }, 30000);
-- 
2.9.3

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [WoK] Removing sessionStorage call in wok.main.js

Posted by Aline Manera 4 years, 1 month ago
Applied. Thanks.

Regards,

Aline Manera

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel