[Kimchi-devel] [PATCH] [Kimchi] Bug fix: Display full Volume dropdown menu content even when pool has few volumes

Aline Manera posted 1 patch 4 years, 1 month ago
Failed in applying to current master (apply log)
ui/css/kimchi.css                | 6 +++++-
ui/css/src/modules/_storage.scss | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)

[Kimchi-devel] [PATCH] [Kimchi] Bug fix: Display full Volume dropdown menu content even when pool has few volumes

Posted by Aline Manera 4 years, 1 month ago
When the storage pool has one or two storage volumes, the dropdown menu
would not display all the options as the height set to it was not
enough.
To avoid that, increase the min-height configuration.

Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
---
 ui/css/kimchi.css                | 6 +++++-
 ui/css/src/modules/_storage.scss | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ui/css/kimchi.css b/ui/css/kimchi.css
index 0af9293..2d44919 100644
--- a/ui/css/kimchi.css
+++ b/ui/css/kimchi.css
@@ -2514,11 +2514,15 @@ ul {
 
 #storage-root-container .volumes .volumeslist {
   padding: 22px;
-  min-height: 136px;
+  min-height: 188px;
   max-height: 505px;
   overflow: hidden;
 }
 
+#storage-root-container .volumes .volumeslist .wok-list {
+  min-height: inherit;
+}
+
 #storage-root-container .volumes .volumeslist .row {
   font-size: 0;
   margin-bottom: 22px;
diff --git a/ui/css/src/modules/_storage.scss b/ui/css/src/modules/_storage.scss
index 70cb3fa..c8b84a9 100644
--- a/ui/css/src/modules/_storage.scss
+++ b/ui/css/src/modules/_storage.scss
@@ -82,11 +82,15 @@
 
         .volumeslist {
             padding: 22px;
-            min-height: 136px;
+            min-height: 188px;
             max-height: 505px;
             overflow: hidden;
         }
 
+        .volumeslist .wok-list {
+            min-height: inherit;
+        }
+
         .volumeslist .row {
             font-size: 0;
             margin-bottom: 22px;
-- 
2.9.3

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [Kimchi] Bug fix: Display full Volume dropdown menu content even when pool has few volumes

Posted by Daniel Henrique Barboza 4 years, 1 month ago
Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com>

On 03/21/2017 05:49 PM, Aline Manera wrote:
> When the storage pool has one or two storage volumes, the dropdown menu
> would not display all the options as the height set to it was not
> enough.
> To avoid that, increase the min-height configuration.
>
> Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
> ---
>   ui/css/kimchi.css                | 6 +++++-
>   ui/css/src/modules/_storage.scss | 6 +++++-
>   2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/ui/css/kimchi.css b/ui/css/kimchi.css
> index 0af9293..2d44919 100644
> --- a/ui/css/kimchi.css
> +++ b/ui/css/kimchi.css
> @@ -2514,11 +2514,15 @@ ul {
>
>   #storage-root-container .volumes .volumeslist {
>     padding: 22px;
> -  min-height: 136px;
> +  min-height: 188px;
>     max-height: 505px;
>     overflow: hidden;
>   }
>
> +#storage-root-container .volumes .volumeslist .wok-list {
> +  min-height: inherit;
> +}
> +
>   #storage-root-container .volumes .volumeslist .row {
>     font-size: 0;
>     margin-bottom: 22px;
> diff --git a/ui/css/src/modules/_storage.scss b/ui/css/src/modules/_storage.scss
> index 70cb3fa..c8b84a9 100644
> --- a/ui/css/src/modules/_storage.scss
> +++ b/ui/css/src/modules/_storage.scss
> @@ -82,11 +82,15 @@
>
>           .volumeslist {
>               padding: 22px;
> -            min-height: 136px;
> +            min-height: 188px;
>               max-height: 505px;
>               overflow: hidden;
>           }
>
> +        .volumeslist .wok-list {
> +            min-height: inherit;
> +        }
> +
>           .volumeslist .row {
>               font-size: 0;
>               margin-bottom: 22px;

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [Kimchi] Bug fix: Display full Volume dropdown menu content even when pool has few volumes

Posted by Aline Manera 4 years, 1 month ago
Applied. Thanks.

Regards,

Aline Manera

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel