[Kimchi-devel] [PATCH] [Kimchi] Bug fix: Preserve "View Gallery" button location when opening Storage Volume actions menu

Aline Manera posted 1 patch 4 years, 1 month ago
Failed in applying to current master (apply log)
ui/js/src/kimchi.storage_main.js | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

[Kimchi-devel] [PATCH] [Kimchi] Bug fix: Preserve "View Gallery" button location when opening Storage Volume actions menu

Posted by Aline Manera 4 years, 1 month ago
The "View Gallery" button was being moved to left when opening the
Storage Volume actions drop down menu.
Fix it.

Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
---
 ui/js/src/kimchi.storage_main.js | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js
index bfde50c..0429456 100644
--- a/ui/js/src/kimchi.storage_main.js
+++ b/ui/js/src/kimchi.storage_main.js
@@ -1,7 +1,7 @@
 /*
  * Project Kimchi
  *
- * Copyright IBM Corp, 2013-2016
+ * Copyright IBM Corp, 2013-2017
  *
  * Licensed under the Apache License, Version 2.0 (the 'License');
  * you may not use this file except in compliance with the License.
@@ -640,11 +640,6 @@ kimchi.doListVolumes = function(poolObj) {
 
         $('.pool-action', volumeDiv).on('show.bs.dropdown', function () {
             $(volumeDiv).scrollTop(0);
-            $(this).css('position','absolute');
-            $('.toggle-gallery',volumeDiv).css({
-                'position':'absolute',
-                'margin-top': '1px'
-            });
             $(volumeDiv).bind('mousewheel DOMMouseScroll', function(e) {
                 e.preventDefault();
             });
-- 
2.9.3

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [Kimchi] Bug fix: Preserve "View Gallery" button location when opening Storage Volume actions menu

Posted by Daniel Henrique Barboza 4 years, 1 month ago
Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com>

On 03/21/2017 04:12 PM, Aline Manera wrote:
> The "View Gallery" button was being moved to left when opening the
> Storage Volume actions drop down menu.
> Fix it.
>
> Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com>
> ---
>   ui/js/src/kimchi.storage_main.js | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js
> index bfde50c..0429456 100644
> --- a/ui/js/src/kimchi.storage_main.js
> +++ b/ui/js/src/kimchi.storage_main.js
> @@ -1,7 +1,7 @@
>   /*
>    * Project Kimchi
>    *
> - * Copyright IBM Corp, 2013-2016
> + * Copyright IBM Corp, 2013-2017
>    *
>    * Licensed under the Apache License, Version 2.0 (the 'License');
>    * you may not use this file except in compliance with the License.
> @@ -640,11 +640,6 @@ kimchi.doListVolumes = function(poolObj) {
>
>           $('.pool-action', volumeDiv).on('show.bs.dropdown', function () {
>               $(volumeDiv).scrollTop(0);
> -            $(this).css('position','absolute');
> -            $('.toggle-gallery',volumeDiv).css({
> -                'position':'absolute',
> -                'margin-top': '1px'
> -            });
>               $(volumeDiv).bind('mousewheel DOMMouseScroll', function(e) {
>                   e.preventDefault();
>               });

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH] [Kimchi] Bug fix: Preserve "View Gallery" button location when opening Storage Volume actions menu

Posted by Aline Manera 4 years, 1 month ago
Applied. Thanks.

Regards,

Aline Manera

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel