[Kimchi-devel] [PATCH V2] [Wok 0/7] Plugins management UI

Aline Manera posted 7 patches 4 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/kimchi-wok tags/patchew/20170213135704.7556-1-alinefm@linux.vnet.ibm.com
Test Unit Tests passed
src/wok/root.py                                    |   4 +-
tests/test_server.py                               |   1 -
ui/config/tab-ext.xml                              |   9 +-
ui/css/Makefile.am                                 |  10 +-
ui/css/settings.css                                | 144 +++++--
ui/css/src/settings.scss                           | 158 +++++---
ui/css/src/user-log.scss                           | 116 ++++++
ui/css/user-log.css                                | 159 ++++++++
ui/css/wok.css                                     |   4 +-
ui/images/pl.png                                   | Bin 0 -> 2904 bytes
ui/js/src/wok.api.js                               |  66 +++-
ui/js/src/wok.logos.js                             |  79 ++--
ui/js/src/wok.main.js                              |  87 +++--
ui/js/wok.bootgrid.js                              |   6 +-
ui/js/wok.settings.js                              | 157 ++++++++
ui/js/wok.user-log.js                              | 434 ++++++++++-----------
ui/pages/i18n.json.tmpl                            |   4 +
ui/pages/tabs/settings.html.tmpl                   |  57 ++-
...-search.html.tmpl => user-log-search.html.tmpl} |   0
ui/pages/tabs/user-log.html.tmpl                   |  74 ++++
20 files changed, 1121 insertions(+), 448 deletions(-)
create mode 100644 ui/css/src/user-log.scss
create mode 100644 ui/css/user-log.css
create mode 100644 ui/images/pl.png
create mode 100644 ui/js/wok.settings.js
rename ui/pages/tabs/{settings-search.html.tmpl => user-log-search.html.tmpl} (100%)
create mode 100644 ui/pages/tabs/user-log.html.tmpl

[Kimchi-devel] [PATCH V2] [Wok 0/7] Plugins management UI

Posted by Aline Manera 4 years, 2 months ago
V1 -> V2:
- Remove print statement =)

Aline Manera (7):
  Fix last page cookie setting
  Fix test case by removing authorization verification for
    css/theme-default.min.css
  Move AJAX API calls to wok.api.js
  Fix indentation on wok.user-log.js file
  Move "User Log Activity" tab to "Activity Log" tab instead of
    "Settings"
  Cache plugins information on UI to avoid multiple requests
  Plugins management UI

 src/wok/root.py                                    |   4 +-
 tests/test_server.py                               |   1 -
 ui/config/tab-ext.xml                              |   9 +-
 ui/css/Makefile.am                                 |  10 +-
 ui/css/settings.css                                | 144 +++++--
 ui/css/src/settings.scss                           | 158 +++++---
 ui/css/src/user-log.scss                           | 116 ++++++
 ui/css/user-log.css                                | 159 ++++++++
 ui/css/wok.css                                     |   4 +-
 ui/images/pl.png                                   | Bin 0 -> 2904 bytes
 ui/js/src/wok.api.js                               |  66 +++-
 ui/js/src/wok.logos.js                             |  79 ++--
 ui/js/src/wok.main.js                              |  87 +++--
 ui/js/wok.bootgrid.js                              |   6 +-
 ui/js/wok.settings.js                              | 157 ++++++++
 ui/js/wok.user-log.js                              | 434 ++++++++++-----------
 ui/pages/i18n.json.tmpl                            |   4 +
 ui/pages/tabs/settings.html.tmpl                   |  57 ++-
 ...-search.html.tmpl => user-log-search.html.tmpl} |   0
 ui/pages/tabs/user-log.html.tmpl                   |  74 ++++
 20 files changed, 1121 insertions(+), 448 deletions(-)
 create mode 100644 ui/css/src/user-log.scss
 create mode 100644 ui/css/user-log.css
 create mode 100644 ui/images/pl.png
 create mode 100644 ui/js/wok.settings.js
 rename ui/pages/tabs/{settings-search.html.tmpl => user-log-search.html.tmpl} (100%)
 create mode 100644 ui/pages/tabs/user-log.html.tmpl

-- 
2.9.3

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH V2] [Wok 0/7] Plugins management UI

Posted by Lucio Correia 4 years, 2 months ago
Reviewed-By: Lucio Correia <luciojhc@linux.vnet.ibm.com>

On 13/02/2017 11:56, Aline Manera wrote:
> V1 -> V2:
> - Remove print statement =)
>
> Aline Manera (7):
>   Fix last page cookie setting
>   Fix test case by removing authorization verification for
>     css/theme-default.min.css
>   Move AJAX API calls to wok.api.js
>   Fix indentation on wok.user-log.js file
>   Move "User Log Activity" tab to "Activity Log" tab instead of
>     "Settings"
>   Cache plugins information on UI to avoid multiple requests
>   Plugins management UI
>
>  src/wok/root.py                                    |   4 +-
>  tests/test_server.py                               |   1 -
>  ui/config/tab-ext.xml                              |   9 +-
>  ui/css/Makefile.am                                 |  10 +-
>  ui/css/settings.css                                | 144 +++++--
>  ui/css/src/settings.scss                           | 158 +++++---
>  ui/css/src/user-log.scss                           | 116 ++++++
>  ui/css/user-log.css                                | 159 ++++++++
>  ui/css/wok.css                                     |   4 +-
>  ui/images/pl.png                                   | Bin 0 -> 2904 bytes
>  ui/js/src/wok.api.js                               |  66 +++-
>  ui/js/src/wok.logos.js                             |  79 ++--
>  ui/js/src/wok.main.js                              |  87 +++--
>  ui/js/wok.bootgrid.js                              |   6 +-
>  ui/js/wok.settings.js                              | 157 ++++++++
>  ui/js/wok.user-log.js                              | 434 ++++++++++-----------
>  ui/pages/i18n.json.tmpl                            |   4 +
>  ui/pages/tabs/settings.html.tmpl                   |  57 ++-
>  ...-search.html.tmpl => user-log-search.html.tmpl} |   0
>  ui/pages/tabs/user-log.html.tmpl                   |  74 ++++
>  20 files changed, 1121 insertions(+), 448 deletions(-)
>  create mode 100644 ui/css/src/user-log.scss
>  create mode 100644 ui/css/user-log.css
>  create mode 100644 ui/images/pl.png
>  create mode 100644 ui/js/wok.settings.js
>  rename ui/pages/tabs/{settings-search.html.tmpl => user-log-search.html.tmpl} (100%)
>  create mode 100644 ui/pages/tabs/user-log.html.tmpl
>


-- 
Lucio Correia

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH V2] [Wok 0/7] Plugins management UI

Posted by Lucio Correia 4 years, 2 months ago


-------- Forwarded Message --------
Subject: Re: [Kimchi-devel] [PATCH V2] [Wok 0/7] Plugins management UI
Date: Mon, 13 Feb 2017 13:50:04 -0200
From: Lucio Correia <luciojhc@linux.vnet.ibm.com>
Reply-To: luciojhc@linux.vnet.ibm.com
Organization: IBM
To: kimchi-devel@ovirt.org

Reviewed-By: Lucio Correia <luciojhc@linux.vnet.ibm.com>

On 13/02/2017 11:56, Aline Manera wrote:
> V1 -> V2:
> - Remove print statement =)
>
> Aline Manera (7):
>   Fix last page cookie setting
>   Fix test case by removing authorization verification for
>     css/theme-default.min.css
>   Move AJAX API calls to wok.api.js
>   Fix indentation on wok.user-log.js file
>   Move "User Log Activity" tab to "Activity Log" tab instead of
>     "Settings"
>   Cache plugins information on UI to avoid multiple requests
>   Plugins management UI
>
>  src/wok/root.py                                    |   4 +-
>  tests/test_server.py                               |   1 -
>  ui/config/tab-ext.xml                              |   9 +-
>  ui/css/Makefile.am                                 |  10 +-
>  ui/css/settings.css                                | 144 +++++--
>  ui/css/src/settings.scss                           | 158 +++++---
>  ui/css/src/user-log.scss                           | 116 ++++++
>  ui/css/user-log.css                                | 159 ++++++++
>  ui/css/wok.css                                     |   4 +-
>  ui/images/pl.png                                   | Bin 0 -> 2904 bytes
>  ui/js/src/wok.api.js                               |  66 +++-
>  ui/js/src/wok.logos.js                             |  79 ++--
>  ui/js/src/wok.main.js                              |  87 +++--
>  ui/js/wok.bootgrid.js                              |   6 +-
>  ui/js/wok.settings.js                              | 157 ++++++++
>  ui/js/wok.user-log.js                              | 434 ++++++++++-----------
>  ui/pages/i18n.json.tmpl                            |   4 +
>  ui/pages/tabs/settings.html.tmpl                   |  57 ++-
>  ...-search.html.tmpl => user-log-search.html.tmpl} |   0
>  ui/pages/tabs/user-log.html.tmpl                   |  74 ++++
>  20 files changed, 1121 insertions(+), 448 deletions(-)
>  create mode 100644 ui/css/src/user-log.scss
>  create mode 100644 ui/css/user-log.css
>  create mode 100644 ui/images/pl.png
>  create mode 100644 ui/js/wok.settings.js
>  rename ui/pages/tabs/{settings-search.html.tmpl => user-log-search.html.tmpl} (100%)
>  create mode 100644 ui/pages/tabs/user-log.html.tmpl
>


-- 
Lucio Correia

-- 
Lucio Correia

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel

Re: [Kimchi-devel] [PATCH V2] [Wok 0/7] Plugins management UI

Posted by Aline Manera 4 years, 2 months ago
Applied. Thanks.

Regards,

Aline Manera

_______________________________________________
Kimchi-devel mailing list
Kimchi-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel