1. Patchew
  2. Seabios
  3. View series

[SeaBIOS] Re: regression: cannot boot from nvme anymore, disabling 64bit pci io window helps

Gerd Hoffmann posted 1 patch 2 years ago
Failed in applying to current master (apply log)
src/fw/pciinit.c | 2 ++
1 file changed, 2 insertions(+)
[SeaBIOS] Re: regression: cannot boot from nvme anymore, disabling 64bit pci io window helps
Posted by Gerd Hoffmann 2 years ago 
  Hi,

> After an update some time ago, a VM wit 8GB RAM cannot boot from nvme anymore.

From 7b54087dbd7f201a6cdb2794518c71a84aa0d8a6 Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 15 Jul 2024 10:53:23 +0200
Subject: [PATCH] pciinit: ignore nvme for 64-bit mmio window

Add nvme drives to the list of devices which are not
moved to the 64-bit mmio window.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 src/fw/pciinit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
index b3e359d7fe62..f6aa1a554853 100644
--- a/src/fw/pciinit.c
+++ b/src/fw/pciinit.c
@@ -764,6 +764,8 @@ static void pci_region_migrate_64bit_entries(struct pci_region *from,
             continue;
         if (entry->dev->class == PCI_CLASS_SERIAL_USB)
             continue;
+        if (entry->dev->class == PCI_CLASS_STORAGE_NVME)
+            continue;
         // Move from source list to destination list.
         hlist_del(&entry->node);
         hlist_add(&entry->node, last);
-- 
2.45.2

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: regression: cannot boot from nvme anymore, disabling 64bit pci io window helps
Posted by Marek Marczykowski-Górecki 2 years ago 
On Mon, Jul 15, 2024 at 10:59:12AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > After an update some time ago, a VM wit 8GB RAM cannot boot from nvme anymore.
> 
> From 7b54087dbd7f201a6cdb2794518c71a84aa0d8a6 Mon Sep 17 00:00:00 2001
> From: Gerd Hoffmann <kraxel@redhat.com>
> Date: Mon, 15 Jul 2024 10:53:23 +0200
> Subject: [PATCH] pciinit: ignore nvme for 64-bit mmio window
> 
> Add nvme drives to the list of devices which are not
> moved to the 64-bit mmio window.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Thanks, I can confirm this helps too.

Tested-By: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

> ---
>  src/fw/pciinit.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
> index b3e359d7fe62..f6aa1a554853 100644
> --- a/src/fw/pciinit.c
> +++ b/src/fw/pciinit.c
> @@ -764,6 +764,8 @@ static void pci_region_migrate_64bit_entries(struct pci_region *from,
>              continue;
>          if (entry->dev->class == PCI_CLASS_SERIAL_USB)
>              continue;
> +        if (entry->dev->class == PCI_CLASS_STORAGE_NVME)
> +            continue;
>          // Move from source list to destination list.
>          hlist_del(&entry->node);
>          hlist_add(&entry->node, last);
> -- 
> 2.45.2
> 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: regression: cannot boot from nvme anymore, disabling 64bit pci io window helps
Posted by Marek Marczykowski-Górecki 3 weeks, 1 day ago 
On Mon, Jul 15, 2024 at 11:04:43AM +0200, Marek Marczykowski-Górecki wrote:
> On Mon, Jul 15, 2024 at 10:59:12AM +0200, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > After an update some time ago, a VM wit 8GB RAM cannot boot from nvme anymore.
> > 
> > From 7b54087dbd7f201a6cdb2794518c71a84aa0d8a6 Mon Sep 17 00:00:00 2001
> > From: Gerd Hoffmann <kraxel@redhat.com>
> > Date: Mon, 15 Jul 2024 10:53:23 +0200
> > Subject: [PATCH] pciinit: ignore nvme for 64-bit mmio window
> > 
> > Add nvme drives to the list of devices which are not
> > moved to the 64-bit mmio window.
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Thanks, I can confirm this helps too.
> 
> Tested-By: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Hi, I think this patch was forgotten...

> 
> > ---
> >  src/fw/pciinit.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
> > index b3e359d7fe62..f6aa1a554853 100644
> > --- a/src/fw/pciinit.c
> > +++ b/src/fw/pciinit.c
> > @@ -764,6 +764,8 @@ static void pci_region_migrate_64bit_entries(struct pci_region *from,
> >              continue;
> >          if (entry->dev->class == PCI_CLASS_SERIAL_USB)
> >              continue;
> > +        if (entry->dev->class == PCI_CLASS_STORAGE_NVME)
> > +            continue;
> >          // Move from source list to destination list.
> >          hlist_del(&entry->node);
> >          hlist_add(&entry->node, last);
> > -- 
> > 2.45.2
> > 
> 
> -- 
> Best Regards,
> Marek Marczykowski-Górecki
> Invisible Things Lab



> _______________________________________________
> SeaBIOS mailing list -- seabios@seabios.org
> To unsubscribe send an email to seabios-leave@seabios.org


-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: regression: cannot boot from nvme anymore, disabling 64bit pci io window helps
Posted by Gerd Hoffmann via SeaBIOS 3 weeks ago 
  Hi,

> > > Subject: [PATCH] pciinit: ignore nvme for 64-bit mmio window

> > Tested-By: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> 
> Hi, I think this patch was forgotten...

Indeed.  Pushed now.

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: regression: cannot boot from nvme anymore, disabling 64bit pci io window helps
Posted by Marek Marczykowski-Górecki 3 weeks ago 
On Tue, Jul 07, 2026 at 09:51:53AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > > > Subject: [PATCH] pciinit: ignore nvme for 64-bit mmio window
> 
> > > Tested-By: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > 
> > Hi, I think this patch was forgotten...
> 
> Indeed.  Pushed now.

Thanks!

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.