[SeaBIOS] [PATCH] Makefile: Allow overriding defconfig

Paul Menzel posted 1 patch 17 weeks ago
Failed in applying to current master (apply log)
Makefile                 | 3 +++
scripts/kconfig/Makefile | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)

[SeaBIOS] [PATCH] Makefile: Allow overriding defconfig

Posted by Paul Menzel 17 weeks ago
From: Stefan Reinauer <reinauer@chromium.org>
Date: Fri, 31 Jan 2014 13:53:58 -0800

Allow specifying a file instead of /dev/null for defconfig.

BUG=none
BRANCH=none
TEST=emerge-panther chromeos-seabios works and produces
      usable SeaBIOS image

Change-Id: I01d902eb9a6dff9ced7e3dd061aa33f831a64e8c
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/185752
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Commit-Queue: Stefan Reinauer <reinauer@chromium.org>
Tested-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/227448
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
---
  Makefile                 | 3 +++
  scripts/kconfig/Makefile | 2 +-
  2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 5f7d537..b57b529 100644
--- a/Makefile
+++ b/Makefile
@@ -7,6 +7,9 @@
  # Output directory
  OUT=out/

+# Default config (can be overriden)
+KCONFIG_DEFCONFIG?=/dev/null
+
  # Common command definitions
  export HOSTCC             := $(CC)
  export CONFIG_SHELL       := sh
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 1c12936..a3fe942 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -96,7 +96,7 @@ savedefconfig: $(obj)/conf

  defconfig: $(obj)/conf
  	@echo "  Build default config"
-	$(Q)$< --defconfig=/dev/null $(Kconfig)
+	$(Q)$< --defconfig=$(KCONFIG_DEFCONFIG) $(Kconfig)

  %_defconfig: $(obj)/conf
  	$(Q)$< --defconfig=arch/$(SRCARCH)/configs/$@ $(Kconfig)
-- 
2.25.1
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] Makefile: Allow overriding defconfig

Posted by Kevin O'Connor 17 weeks ago
On Mon, Mar 16, 2020 at 05:36:50PM +0100, Paul Menzel wrote:
> From: Stefan Reinauer <reinauer@chromium.org>
> Date: Fri, 31 Jan 2014 13:53:58 -0800
> 
> Allow specifying a file instead of /dev/null for defconfig.

What's the high-level use case for this change?  Couldn't the same
functionality be obtained by doing:

cp /path/to/my/template/config .config
make olddefconfig

-Kevin


> 
> BUG=none
> BRANCH=none
> TEST=emerge-panther chromeos-seabios works and produces
>      usable SeaBIOS image
> 
> Change-Id: I01d902eb9a6dff9ced7e3dd061aa33f831a64e8c
> Signed-off-by: Stefan Reinauer <reinauer@google.com>
> Reviewed-on: https://chromium-review.googlesource.com/185752
> Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
> Commit-Queue: Stefan Reinauer <reinauer@chromium.org>
> Tested-by: Stefan Reinauer <reinauer@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/227448
> Reviewed-by: Marc Jones <marc.jones@se-eng.com>
> ---
>  Makefile                 | 3 +++
>  scripts/kconfig/Makefile | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 5f7d537..b57b529 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,6 +7,9 @@
>  # Output directory
>  OUT=out/
> 
> +# Default config (can be overriden)
> +KCONFIG_DEFCONFIG?=/dev/null
> +
>  # Common command definitions
>  export HOSTCC             := $(CC)
>  export CONFIG_SHELL       := sh
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 1c12936..a3fe942 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -96,7 +96,7 @@ savedefconfig: $(obj)/conf
> 
>  defconfig: $(obj)/conf
>  	@echo "  Build default config"
> -	$(Q)$< --defconfig=/dev/null $(Kconfig)
> +	$(Q)$< --defconfig=$(KCONFIG_DEFCONFIG) $(Kconfig)
> 
>  %_defconfig: $(obj)/conf
>  	$(Q)$< --defconfig=arch/$(SRCARCH)/configs/$@ $(Kconfig)
> -- 
> 2.25.1
> _______________________________________________
> SeaBIOS mailing list -- seabios@seabios.org
> To unsubscribe send an email to seabios-leave@seabios.org
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] Makefile: Allow overriding defconfig

Posted by Gerd Hoffmann 17 weeks ago
> +# Default config (can be overriden)
> +KCONFIG_DEFCONFIG?=/dev/null

>  defconfig: $(obj)/conf
>  	@echo "  Build default config"
> -	$(Q)$< --defconfig=/dev/null $(Kconfig)
> +	$(Q)$< --defconfig=$(KCONFIG_DEFCONFIG) $(Kconfig)

Looks useful.  "git am" refuses to apply this one too though.

cheers,
  Gerd
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org