[v2] Build system improvements

[SeaBIOS] [PATCH v2 8/9] virtio-blk: Fix indentation for vring_get_buf call

Posted by Jiaxun Yang 2 weeks, 4 days ago

Adjusted the indentation of the vring_get_buf function call to improve code readability and maintain consistency with surrounding code.

Fix warning:

In file included from out/ccode32flat.o.tmp.c:83:
./src/hw/virtio-blk.c:56:9: warning: misleading indentation; statement is not part of the previous 'while' [-Wmisleading-indentation]
   56 |         vring_get_buf(vq, NULL);

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 src/hw/virtio-blk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c
index 137a2c3c75579beae69611e248002d48f947fdac..351692e22e6ebaf63626348e47a0f0533617325e 100644
--- a/src/hw/virtio-blk.c
+++ b/src/hw/virtio-blk.c
@@ -53,7 +53,7 @@ virtio_blk_op_one_segment(struct virtiodrive_s *vdrive,
         usleep(5);
 
     /* Reclaim virtqueue element */
-        vring_get_buf(vq, NULL);
+    vring_get_buf(vq, NULL);
 
     /**
     ** Clear interrupt status register. Avoid leaving interrupts stuck

-- 
2.43.0

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH v2 8/9] virtio-blk: Fix indentation for vring_get_buf call

Posted by Paul Menzel 2 weeks, 4 days ago

Dear Jiaxun,


Thank you for your patch.

Am 03.09.25 um 08:51 schrieb Jiaxun Yang:
> Adjusted the indentation of the vring_get_buf function call to improve code readability and maintain consistency with surrounding code.

I’d use imperative mood present tense: Adjust …

Also, it’d be great if you could wrap the line after 72 characters. 
(Pastes like below should not be wrapped.)

> Fix warning:
> 
> In file included from out/ccode32flat.o.tmp.c:83:
> ./src/hw/virtio-blk.c:56:9: warning: misleading indentation; statement is not part of the previous 'while' [-Wmisleading-indentation]
>     56 |         vring_get_buf(vq, NULL);
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   src/hw/virtio-blk.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c
> index 137a2c3c75579beae69611e248002d48f947fdac..351692e22e6ebaf63626348e47a0f0533617325e 100644
> --- a/src/hw/virtio-blk.c
> +++ b/src/hw/virtio-blk.c
> @@ -53,7 +53,7 @@ virtio_blk_op_one_segment(struct virtiodrive_s *vdrive,
>           usleep(5);
>   
>       /* Reclaim virtqueue element */
> -        vring_get_buf(vq, NULL);
> +    vring_get_buf(vq, NULL);
>   
>       /**
>       ** Clear interrupt status register. Avoid leaving interrupts stuck
> 

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org