Whilst trying to improve QEMU's ESP SCSI implementation with regard to the
NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian
test images with my patches applied.

Further investigation revealed that the SeaBIOS esp-scsi driver inadvertently
relies on existing bugs in QEMU's ESP SCSI emulation to work correctly, so this
series changes the driver to work as described in the NCR datasheet.

With this series applied it is possible for the updated SeaBIOS to boot both
QEMU current git HEAD as well as my local WIP branch containing various fixes
and improvements to QEMU's ESP SCSI emulation.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

v3:
- Add R-B tags for patches 1 and 2 from Paolo
- Add patch 3 to handle another bug to be fixed in QEMU's ESP emulation

v2:
- Fix typo in patch 2 commit message
- Add reference to datasheet in patch 2 commit message as requested by Paul


Mark Cave-Ayland (3):
  esp-scsi: flush FIFO before sending SCSI command
  esp-scsi: check for INTR_BS/INTR_FC instead of STAT_TC for command
    completion
  esp-scsi: handle non-DMA SCSI commands with no data phase

 src/hw/esp-scsi.c | 49 +++++++++++++++++++++++++++++++++--------------
 1 file changed, 35 insertions(+), 14 deletions(-)

-- 
2.39.2

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

On Mon, Aug 07, 2023 at 07:52:57AM +0100, Mark Cave-Ayland wrote:
> Whilst trying to improve QEMU's ESP SCSI implementation with regard to the
> NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian
> test images with my patches applied.
> 
> Further investigation revealed that the SeaBIOS esp-scsi driver inadvertently
> relies on existing bugs in QEMU's ESP SCSI emulation to work correctly, so this
> series changes the driver to work as described in the NCR datasheet.
> 
> With this series applied it is possible for the updated SeaBIOS to boot both
> QEMU current git HEAD as well as my local WIP branch containing various fixes
> and improvements to QEMU's ESP SCSI emulation.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Series committed.

thanks,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org