[SeaBIOS] [PATCH 0/2] print some errors to the screen

Gerd Hoffmann posted 2 patches 9 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20230503092201.487130-1-kraxel@redhat.com
src/output.h        |  5 +++++
src/hw/blockcmd.c   |  2 +-
src/hw/virtio-blk.c |  4 ++--
src/output.c        | 17 +++++++++++++++++
src/post.c          |  4 ++++
5 files changed, 29 insertions(+), 3 deletions(-)
[SeaBIOS] [PATCH 0/2] print some errors to the screen
Posted by Gerd Hoffmann 9 months, 3 weeks ago

Gerd Hoffmann (2):
  add hwerr_printf function for threads
  display error message for blocksizes != 512

 src/output.h        |  5 +++++
 src/hw/blockcmd.c   |  2 +-
 src/hw/virtio-blk.c |  4 ++--
 src/output.c        | 17 +++++++++++++++++
 src/post.c          |  4 ++++
 5 files changed, 29 insertions(+), 3 deletions(-)

-- 
2.40.1

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: [PATCH 0/2] print some errors to the screen
Posted by Kevin O'Connor 9 months, 3 weeks ago
For what it is worth, I'm not sure sending debug/error messages to the
vga screen is a good long-term plan.  I fear it will be more
frustration than help to users.  Sure, having the VM not start isn't a
fun experience, but I'm not sure a weird cryptic error message that
flashes on the screen for a split second is an improvement.

Enabling the seabios log from qemu is an annoying step to have to
take, but I suspect taking that step may ultimately be necessary in
many cases.

Cheers,
-Kevin


On Wed, May 03, 2023 at 11:21:59AM +0200, Gerd Hoffmann wrote:
> 
> 
> Gerd Hoffmann (2):
>   add hwerr_printf function for threads
>   display error message for blocksizes != 512
> 
>  src/output.h        |  5 +++++
>  src/hw/blockcmd.c   |  2 +-
>  src/hw/virtio-blk.c |  4 ++--
>  src/output.c        | 17 +++++++++++++++++
>  src/post.c          |  4 ++++
>  5 files changed, 29 insertions(+), 3 deletions(-)
> 
> -- 
> 2.40.1
> 
> _______________________________________________
> SeaBIOS mailing list -- seabios@seabios.org
> To unsubscribe send an email to seabios-leave@seabios.org
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: [PATCH 0/2] print some errors to the screen
Posted by Gerd Hoffmann 9 months, 3 weeks ago
On Thu, May 04, 2023 at 02:28:05PM -0400, Kevin O'Connor wrote:
> For what it is worth, I'm not sure sending debug/error messages to the
> vga screen is a good long-term plan.  I fear it will be more
> frustration than help to users.  Sure, having the VM not start isn't a
> fun experience, but I'm not sure a weird cryptic error message that
> flashes on the screen for a split second is an improvement.

It surely doesn't make sense for most errors, patch #2 switches over
only the errors for unsupported blocksizes.  That actually happens
in practice.  And when the VM doesn't boot the message will typically
continue to be displayed ...

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: [PATCH 0/2] print some errors to the screen
Posted by Kevin O'Connor 9 months, 2 weeks ago
On Fri, May 05, 2023 at 09:04:41AM +0200, Gerd Hoffmann wrote:
> On Thu, May 04, 2023 at 02:28:05PM -0400, Kevin O'Connor wrote:
> > For what it is worth, I'm not sure sending debug/error messages to the
> > vga screen is a good long-term plan.  I fear it will be more
> > frustration than help to users.  Sure, having the VM not start isn't a
> > fun experience, but I'm not sure a weird cryptic error message that
> > flashes on the screen for a split second is an improvement.
> 
> It surely doesn't make sense for most errors, patch #2 switches over
> only the errors for unsupported blocksizes.  That actually happens
> in practice.  And when the VM doesn't boot the message will typically
> continue to be displayed ...

I understand.  For what it is worth, I'm still unsure this is a good
long term plan though.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org