[SeaBIOS] [PATCH] qemu: disable builtin acpi and smbios tables by default.

Gerd Hoffmann posted 1 patch 5 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20220421134640.1700498-1-kraxel@redhat.com
src/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[SeaBIOS] [PATCH] qemu: disable builtin acpi and smbios tables by default.
Posted by Gerd Hoffmann 5 months, 1 week ago
qemu provides acpi and smbios tables via fw_cfg for many years
now.  The builtin tables shipped by seabios are only used as
fallback for old qemu versions.

qemu is about to drop backward compatibility for old versions,
machine types for versions 1.4 to 1.7 are deprecated, which
turns the fallbacks into dead code.

This patch flips the default for the config options controlling
the fallback smbios and acpi tables from 'Yes' to 'No'.  Eventually
the code will be removed altogether at some point in the future.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 src/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index 3a8ffa15fded..83ddf45143c3 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -494,25 +494,25 @@ menu "BIOS Tables"
             Support generation of MPTable.
     config SMBIOS
         bool "SMBIOS"
-        default y
+        default n
         help
             Support generation of SM BIOS tables.  This is also
             sometimes called DMI.
     config ACPI
         bool "ACPI"
-        default y
+        default n
         help
             Support generation of ACPI tables.
     config ACPI_DSDT
         bool "Include default ACPI DSDT"
-        default y
+        default n
         depends on ACPI
         help
             Include default DSDT ACPI table in BIOS.
             Required for QEMU 1.3 and older.
             This option can be disabled for QEMU 1.4 and newer
             to save some space in the ROM file.
-            If unsure, say Y.
+            If unsure, say N.
     config FW_ROMFILE_LOAD
         bool "Load BIOS tables from ROM files"
         depends on QEMU_HARDWARE
-- 
2.35.1

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
[SeaBIOS] Re: [PATCH] qemu: disable builtin acpi and smbios tables by default.
Posted by Igor Mammedov 5 months, 1 week ago
On Thu, 21 Apr 2022 15:46:40 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

> qemu provides acpi and smbios tables via fw_cfg for many years
> now.  The builtin tables shipped by seabios are only used as
> fallback for old qemu versions.
> 
> qemu is about to drop backward compatibility for old versions,
> machine types for versions 1.4 to 1.7 are deprecated, which
> turns the fallbacks into dead code.
> 
> This patch flips the default for the config options controlling
> the fallback smbios and acpi tables from 'Yes' to 'No'.  Eventually
> the code will be removed altogether at some point in the future.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  src/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/Kconfig b/src/Kconfig
> index 3a8ffa15fded..83ddf45143c3 100644
> --- a/src/Kconfig
> +++ b/src/Kconfig
> @@ -494,25 +494,25 @@ menu "BIOS Tables"
>              Support generation of MPTable.
>      config SMBIOS
>          bool "SMBIOS"
> -        default y
> +        default n
>          help
>              Support generation of SM BIOS tables.  This is also
>              sometimes called DMI.
>      config ACPI
>          bool "ACPI"
> -        default y
> +        default n
>          help
>              Support generation of ACPI tables.
>      config ACPI_DSDT
>          bool "Include default ACPI DSDT"
> -        default y
> +        default n
>          depends on ACPI
>          help
>              Include default DSDT ACPI table in BIOS.
>              Required for QEMU 1.3 and older.
>              This option can be disabled for QEMU 1.4 and newer
>              to save some space in the ROM file.
> -            If unsure, say Y.
> +            If unsure, say N.
>      config FW_ROMFILE_LOAD
>          bool "Load BIOS tables from ROM files"
>          depends on QEMU_HARDWARE

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org