[v2] Rework NVME page transfers and avoid fsegment allocation

[SeaBIOS] [PATCHv2 0/6] Rework NVME page transfers and avoid fsegment allocation

Kevin O'Connor posted 6 patches 2 years, 3 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20220121164848.2000294-1-kevin@koconnor.net

src/hw/nvme-int.h |  10 ---
src/hw/nvme.c     | 163 ++++++++++++++++++++++------------------------
2 files changed, 78 insertions(+), 95 deletions(-)

Expand all Fold all

[SeaBIOS] [PATCHv2 0/6] Rework NVME page transfers and avoid fsegment allocation

Posted by Kevin O'Connor 2 years, 3 months ago

This is a resend of the previous series.  Changes since last time:

* Patch 1: Fix function comment on nvme_io_xfer()
* Patch 3-5: Added "goto bounce" to nvme_io_xfer() as suggested by Alex
* Patch 6: Added separate "single dma bounce buffer" patch to this series
* Patch 6: Add checking for malloc failure

-Kevin


Kevin O'Connor (6):
  nvme: Rework nvme_io_readwrite() to return -1 on error
  nvme: Add nvme_bounce_xfer() helper function
  nvme: Convert nvme_build_prpl() to nvme_prpl_xfer()
  nvme: Pass prp1 and prp2 directly to nvme_io_xfer()
  nvme: Build the page list in the existing dma buffer
  nvme: Only allocate one dma bounce buffer for all nvme drives

 src/hw/nvme-int.h |  10 ---
 src/hw/nvme.c     | 163 ++++++++++++++++++++++------------------------
 2 files changed, 78 insertions(+), 95 deletions(-)

-- 
2.31.1

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCHv2 0/6] Rework NVME page transfers and avoid fsegment allocation

Posted by Alexander Graf via SeaBIOS 2 years, 3 months ago

On 21.01.22 17:48, Kevin O'Connor wrote:
> This is a resend of the previous series.  Changes since last time:
>
> * Patch 1: Fix function comment on nvme_io_xfer()
> * Patch 3-5: Added "goto bounce" to nvme_io_xfer() as suggested by Alex
> * Patch 6: Added separate "single dma bounce buffer" patch to this series
> * Patch 6: Add checking for malloc failure
>
> -Kevin

Thanks a lot for cleaning up that code! I agree that it's a lot more 
readable after your patches :)

Alex

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org