[v3] pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on q35 with ACPI hotplug enabled

[SeaBIOS] [PATCH v3 0/2] pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on q35 with ACPI hotplug enabled

Igor Mammedov posted 2 patches 2 years, 4 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20211129114812.231849-1-imammedo@redhat.com

src/fw/pciinit.c | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)

Expand all Fold all

[SeaBIOS] [PATCH v3 0/2] pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on q35 with ACPI hotplug enabled

Posted by Igor Mammedov 2 years, 4 months ago

Since QEMU-6.1, Q35 machine is using ACPI PCI hotplug by default.
However SeaBIOS did not take in account pcie-pci-bridge and treated it
as any other PCIe device which is not correct in the case of the bridge.

Patch [1/2] fixes main issue by treating the bridge as a device with
possible SHPC capability.
Patch [2/2] fixes missed IO reservation, by making sure that in the case of
the bridge firmware reserves IO resource.

Igor Mammedov (2):
  pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on
    q35
  pci: let firmware reserve IO for pcie-pci-bridge

 src/fw/pciinit.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

-- 
2.27.0

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH v3 0/2] pci: reserve resources for pcie-pci-bridge to fix regressed hotplug on q35 with ACPI hotplug enabled

Posted by Kevin O'Connor 2 years, 4 months ago

On Mon, Nov 29, 2021 at 06:48:10AM -0500, Igor Mammedov wrote:
> Since QEMU-6.1, Q35 machine is using ACPI PCI hotplug by default.
> However SeaBIOS did not take in account pcie-pci-bridge and treated it
> as any other PCIe device which is not correct in the case of the bridge.
> 
> Patch [1/2] fixes main issue by treating the bridge as a device with
> possible SHPC capability.
> Patch [2/2] fixes missed IO reservation, by making sure that in the case of
> the bridge firmware reserves IO resource.

Thanks.  I committed this series.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org