tcgbios: Use the proper hashes for the TPM 2 PCR banks

[SeaBIOS] [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

Stefan Berger posted 2 patches 2 years, 10 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20210614173549.1920855-1-stefanb@linux.ibm.com

Makefile      |   2 +-
src/sha.h     |  11 +++
src/sha1.c    |   8 +-
src/sha1.h    |   8 --
src/sha256.c  | 211 +++++++++++++++++++++++++++++++++++++++++++
src/sha512.c  | 244 ++++++++++++++++++++++++++++++++++++++++++++++++++
src/tcgbios.c |  60 +++++++++----
src/x86.h     |   7 ++
8 files changed, 522 insertions(+), 29 deletions(-)
create mode 100644 src/sha.h
delete mode 100644 src/sha1.h
create mode 100644 src/sha256.c
create mode 100644 src/sha512.c

Expand all Fold all

[SeaBIOS] [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

Posted by Stefan Berger 2 years, 10 months ago

This PR adds the implementations for sha{256, 384, 512} and makes use
of the hash implementation when extending the PCRs of the respective
banks rather than always using the sha1 and zero-padding it for the PCR
banks of a TPM 2.

Regards,
    Stefan

Stefan Berger (2):
  Add implementations for sha256, sha384, and sha512
  tcgbios: Use The proper sha function for each PCR bank

 Makefile      |   2 +-
 src/sha.h     |  11 +++
 src/sha1.c    |   8 +-
 src/sha1.h    |   8 --
 src/sha256.c  | 211 +++++++++++++++++++++++++++++++++++++++++++
 src/sha512.c  | 244 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/tcgbios.c |  60 +++++++++----
 src/x86.h     |   7 ++
 8 files changed, 522 insertions(+), 29 deletions(-)
 create mode 100644 src/sha.h
 delete mode 100644 src/sha1.h
 create mode 100644 src/sha256.c
 create mode 100644 src/sha512.c

-- 
2.31.1

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

Posted by Kevin O'Connor 2 years, 10 months ago

On Mon, Jun 14, 2021 at 01:35:47PM -0400, Stefan Berger wrote:
> This PR adds the implementations for sha{256, 384, 512} and makes use
> of the hash implementation when extending the PCRs of the respective
> banks rather than always using the sha1 and zero-padding it for the PCR
> banks of a TPM 2.

Okay, thanks.  Looks fine to me.  If there are no further comments
I'll look to commit this (and the previous tcgbios fix) in a few days.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

Posted by Stefan Berger 2 years, 10 months ago

On 6/14/21 7:20 PM, Kevin O'Connor wrote:
> On Mon, Jun 14, 2021 at 01:35:47PM -0400, Stefan Berger wrote:
>> This PR adds the implementations for sha{256, 384, 512} and makes use
>> of the hash implementation when extending the PCRs of the respective
>> banks rather than always using the sha1 and zero-padding it for the PCR
>> banks of a TPM 2.
> Okay, thanks.  Looks fine to me.  If there are no further comments
> I'll look to commit this (and the previous tcgbios fix) in a few days.

Thanks. Similar patches will go out to SLOF tomorrow.


    Stefan

>
> -Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH 0/2] tcgbios: Use the proper hashes for the TPM 2 PCR banks

Posted by Kevin O'Connor 2 years, 9 months ago

On Mon, Jun 14, 2021 at 01:35:47PM -0400, Stefan Berger wrote:
> This PR adds the implementations for sha{256, 384, 512} and makes use
> of the hash implementation when extending the PCRs of the respective
> banks rather than always using the sha1 and zero-padding it for the PCR
> banks of a TPM 2.

Thanks.  I committed this change.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org