[SeaBIOS] [PATCH v2 0/3] Add support for all HD and QXGA resolutions

Elliot Killick via SeaBIOS posted 3 patches 4 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20210504234338.23766-1-elliotkillick@zohomail.eu
vgasrc/svgamodes.c | 217 +++++++++++++++++++++++++++++----------------
1 file changed, 140 insertions(+), 77 deletions(-)

[SeaBIOS] [PATCH v2 0/3] Add support for all HD and QXGA resolutions

Posted by Elliot Killick via SeaBIOS 4 months, 3 weeks ago
Hi,

This patch series adds support for all HD and QXGA resolutions.

I've taken Gerd's advice on the v1 patch and split the formatting
improvments into a separate patch.

I also tried to take Gerd's advice on removing some of the older colors
depths for higher resolutions. However, upon doing this Windows was no
longer recognizing some of the resolutions so I had to add them back. I
split that up into a separate patch in case anyone wants to try and
reproduce the issue. But, it should be fine to include those common
color depths anyway for maximal compatibility.

Best regards,

Elliot

Elliot Killick (3):
  svgamodes: Add all HD and QXGA resolutions
  svgamodes: Improve formatting
  svgamodes: Add color depths other than just 32-bit

 vgasrc/svgamodes.c | 217 +++++++++++++++++++++++++++++----------------
 1 file changed, 140 insertions(+), 77 deletions(-)

-- 
2.30.0


_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

Posted by Kevin O'Connor 4 months, 1 week ago
On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
> Hi,
> 
> This patch series adds support for all HD and QXGA resolutions.
> 
> I've taken Gerd's advice on the v1 patch and split the formatting
> improvments into a separate patch.
> 
> I also tried to take Gerd's advice on removing some of the older colors
> depths for higher resolutions. However, upon doing this Windows was no
> longer recognizing some of the resolutions so I had to add them back. I
> split that up into a separate patch in case anyone wants to try and
> reproduce the issue. But, it should be fine to include those common
> color depths anyway for maximal compatibility.

Thanks, and sorry for the delay in responding.

In general it looks fine to me, but I was hoping Gerd could take a
look as well.  As one minor nit, I think it would be preferable to
squash patch 2 and 3 as it seems odd to remove the modes just to add
them back again.

Cheers,
-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

Posted by Gerd Hoffmann 4 months ago
On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote:
> On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
> > Hi,
> > 
> > This patch series adds support for all HD and QXGA resolutions.
> > 
> > I've taken Gerd's advice on the v1 patch and split the formatting
> > improvments into a separate patch.
> > 
> > I also tried to take Gerd's advice on removing some of the older colors
> > depths for higher resolutions. However, upon doing this Windows was no
> > longer recognizing some of the resolutions so I had to add them back. I
> > split that up into a separate patch in case anyone wants to try and
> > reproduce the issue. But, it should be fine to include those common
> > color depths anyway for maximal compatibility.
> 
> Thanks, and sorry for the delay in responding.
> 
> In general it looks fine to me, but I was hoping Gerd could take a
> look as well.

Looks sane to me.

> As one minor nit, I think it would be preferable to
> squash patch 2 and 3 as it seems odd to remove the modes just to add
> them back again.

You mean squash 1+3 I guess?

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH v2 0/3] Add support for all HD and QXGA resolutions

Posted by Kevin O'Connor 4 months ago
On Fri, May 21, 2021 at 11:03:00AM +0200, Gerd Hoffmann wrote:
> On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote:
> > On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
> > > Hi,
> > > 
> > > This patch series adds support for all HD and QXGA resolutions.
> > > 
> > > I've taken Gerd's advice on the v1 patch and split the formatting
> > > improvments into a separate patch.
> > > 
> > > I also tried to take Gerd's advice on removing some of the older colors
> > > depths for higher resolutions. However, upon doing this Windows was no
> > > longer recognizing some of the resolutions so I had to add them back. I
> > > split that up into a separate patch in case anyone wants to try and
> > > reproduce the issue. But, it should be fine to include those common
> > > color depths anyway for maximal compatibility.
> > 
> > Thanks, and sorry for the delay in responding.
> > 
> > In general it looks fine to me, but I was hoping Gerd could take a
> > look as well.
> 
> Looks sane to me.
> 
> > As one minor nit, I think it would be preferable to
> > squash patch 2 and 3 as it seems odd to remove the modes just to add
> > them back again.
> 
> You mean squash 1+3 I guess?

Sorry, yes.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org