[SeaBIOS] [PATCH] usb boot: add xhci mmio example

Gerd Hoffmann posted 1 patch 1 week ago
Failed in applying to current master (apply log)
src/boot.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

[SeaBIOS] [PATCH] usb boot: add xhci mmio example

Posted by Gerd Hoffmann 1 week ago
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 src/boot.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/boot.c b/src/boot.c
index bd78fb907c5a..1effd802ce06 100644
--- a/src/boot.c
+++ b/src/boot.c
@@ -423,7 +423,9 @@ int bootprio_find_usb(struct usbdevice_s *usbdev, int lun)
 {
     if (!CONFIG_BOOTORDER)
         return -1;
-    // Find usb - for example: /pci@i0cf8/usb@1,2/storage@1/channel@0/disk@0,0
+    // Find usb - examples:
+    //   pci:  /pci@i0cf8/usb@1,2/storage@1/channel@0/disk@0,0
+    //   mmio: /sysbus-xhci@00000000fe900000/storage@1/channel@0/disk@0,0
     char desc[256], *p;
 
     if (usbdev->hub->cntl->pci)
-- 
2.27.0
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] usb boot: add xhci mmio example

Posted by Kevin O'Connor 1 week ago
On Tue, Oct 13, 2020 at 11:10:19AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  src/boot.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/boot.c b/src/boot.c
> index bd78fb907c5a..1effd802ce06 100644
> --- a/src/boot.c
> +++ b/src/boot.c
> @@ -423,7 +423,9 @@ int bootprio_find_usb(struct usbdevice_s *usbdev, int lun)
>  {
>      if (!CONFIG_BOOTORDER)
>          return -1;
> -    // Find usb - for example: /pci@i0cf8/usb@1,2/storage@1/channel@0/disk@0,0
> +    // Find usb - examples:
> +    //   pci:  /pci@i0cf8/usb@1,2/storage@1/channel@0/disk@0,0
> +    //   mmio: /sysbus-xhci@00000000fe900000/storage@1/channel@0/disk@0,0
>      char desc[256], *p;
>  
>      if (usbdev->hub->cntl->pci)

Thanks.  Looks good to me.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] usb boot: add xhci mmio example

Posted by Gerd Hoffmann 1 week ago
On Wed, Oct 14, 2020 at 02:09:21PM -0400, Kevin O'Connor wrote:
> On Tue, Oct 13, 2020 at 11:10:19AM +0200, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  src/boot.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/boot.c b/src/boot.c
> > index bd78fb907c5a..1effd802ce06 100644
> > --- a/src/boot.c
> > +++ b/src/boot.c
> > @@ -423,7 +423,9 @@ int bootprio_find_usb(struct usbdevice_s *usbdev, int lun)
> >  {
> >      if (!CONFIG_BOOTORDER)
> >          return -1;
> > -    // Find usb - for example: /pci@i0cf8/usb@1,2/storage@1/channel@0/disk@0,0
> > +    // Find usb - examples:
> > +    //   pci:  /pci@i0cf8/usb@1,2/storage@1/channel@0/disk@0,0
> > +    //   mmio: /sysbus-xhci@00000000fe900000/storage@1/channel@0/disk@0,0
> >      char desc[256], *p;
> >  
> >      if (usbdev->hub->cntl->pci)
> 
> Thanks.  Looks good to me.

Pushed.

take care,
  Gerd
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org