[SeaBIOS] [PATCH] hw/nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5

Paul Menzel posted 1 patch 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20200727125942.8658-1-pmenzel@molgen.mpg.de
src/hw/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[SeaBIOS] [PATCH] hw/nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5

Posted by Paul Menzel 1 week ago
Currently, setting SeaBIOS debug level to 3, the log is filled with
messages like below.

    ns 1 read lba 11346288+8: 0
    ns 1 read lba 11346296+4: 0
    ns 1 read lba 11346300+4: 0
    ns 1 read lba 11346304+8: 0
    ns 1 read lba 11346312+8: 0
    ns 1 read lba 11346320+8: 0
    ns 1 read lba 11346328+8: 0
    ns 1 read lba 11346336+8: 0

With SeaBIOS as coreboot payload, this fills up the CBMEM console
buffer.

So, increase the debug level to 5, so possible console buffer do not
overflow.

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 src/hw/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/nvme.c b/src/hw/nvme.c
index 41f3b76..6a01204 100644
--- a/src/hw/nvme.c
+++ b/src/hw/nvme.c
@@ -669,7 +669,7 @@ nvme_cmd_readwrite(struct nvme_namespace *ns, struct disk_op_s *op, int write)
         }
 
         res = nvme_io_readwrite(ns, op->lba + i, ns->dma_buffer, blocks, write);
-        dprintf(3, "ns %u %s lba %llu+%u: %d\n", ns->ns_id, write ? "write"
+        dprintf(5, "ns %u %s lba %llu+%u: %d\n", ns->ns_id, write ? "write"
                                                                   : "read",
                 op->lba + i, blocks, res);
 
-- 
2.26.2
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] hw/nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5

Posted by Kevin O'Connor 1 week ago
On Mon, Jul 27, 2020 at 02:59:42PM +0200, Paul Menzel wrote:
> Currently, setting SeaBIOS debug level to 3, the log is filled with
> messages like below.
> 
>     ns 1 read lba 11346288+8: 0
>     ns 1 read lba 11346296+4: 0
>     ns 1 read lba 11346300+4: 0
>     ns 1 read lba 11346304+8: 0
>     ns 1 read lba 11346312+8: 0
>     ns 1 read lba 11346320+8: 0
>     ns 1 read lba 11346328+8: 0
>     ns 1 read lba 11346336+8: 0
> 
> With SeaBIOS as coreboot payload, this fills up the CBMEM console
> buffer.
> 
> So, increase the debug level to 5, so possible console buffer do not
> overflow.

Thanks.  I committed this change.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] hw/nvme: Increase `nvme_cmd_readwrite()` message log level from 3 to 5

Posted by Philippe Mathieu-Daudé 1 week ago
On 7/27/20 2:59 PM, Paul Menzel wrote:
> Currently, setting SeaBIOS debug level to 3, the log is filled with
> messages like below.
> 
>     ns 1 read lba 11346288+8: 0
>     ns 1 read lba 11346296+4: 0
>     ns 1 read lba 11346300+4: 0
>     ns 1 read lba 11346304+8: 0
>     ns 1 read lba 11346312+8: 0
>     ns 1 read lba 11346320+8: 0
>     ns 1 read lba 11346328+8: 0
>     ns 1 read lba 11346336+8: 0
> 
> With SeaBIOS as coreboot payload, this fills up the CBMEM console
> buffer.
> 
> So, increase the debug level to 5, so possible console buffer do not
> overflow.
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  src/hw/nvme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/hw/nvme.c b/src/hw/nvme.c
> index 41f3b76..6a01204 100644
> --- a/src/hw/nvme.c
> +++ b/src/hw/nvme.c
> @@ -669,7 +669,7 @@ nvme_cmd_readwrite(struct nvme_namespace *ns, struct disk_op_s *op, int write)
>          }
>  
>          res = nvme_io_readwrite(ns, op->lba + i, ns->dma_buffer, blocks, write);
> -        dprintf(3, "ns %u %s lba %llu+%u: %d\n", ns->ns_id, write ? "write"
> +        dprintf(5, "ns %u %s lba %llu+%u: %d\n", ns->ns_id, write ? "write"
>                                                                    : "read",
>                  op->lba + i, blocks, res);
>  
> 
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org