[SeaBIOS] [PATCH] cdrom: Demote `scsi_is_ready` return print to debug level

Paul Menzel posted 1 patch 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20200518165804.31743-1-pmenzel@molgen.mpg.de
src/cdrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[SeaBIOS] [PATCH] cdrom: Demote `scsi_is_ready` return print to debug level

Posted by Paul Menzel 1 week ago
Printing the return value of `scsi_is_ready()` is a debug message, so
change the log level from 1 to 5.

    Booting from DVD/CD...
    Device reports MEDIUM NOT PRESENT
    scsi_is_ready returned -1
    Boot failed: Could not read from CDROM (code 0003)

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 src/cdrom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cdrom.c b/src/cdrom.c
index 577d69d..a77671a 100644
--- a/src/cdrom.c
+++ b/src/cdrom.c
@@ -142,7 +142,7 @@ cdrom_boot(struct drive_s *drive)
 
     int ret = scsi_is_ready(&dop);
     if (ret)
-        dprintf(1, "scsi_is_ready returned %d\n", ret);
+        dprintf(5, "scsi_is_ready returned %d\n", ret);
 
     // Read the Boot Record Volume Descriptor
     u8 buffer[CDROM_SECTOR_SIZE];
-- 
2.26.2
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] cdrom: Demote `scsi_is_ready` return print to debug level

Posted by Kevin O'Connor 1 week ago
On Mon, May 18, 2020 at 06:58:04PM +0200, Paul Menzel wrote:
> Printing the return value of `scsi_is_ready()` is a debug message, so
> change the log level from 1 to 5.
> 
>     Booting from DVD/CD...
>     Device reports MEDIUM NOT PRESENT
>     scsi_is_ready returned -1
>     Boot failed: Could not read from CDROM (code 0003)

Thanks.  I committed this patch.

-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH] cdrom: Demote `scsi_is_ready` return print to debug level

Posted by Philippe Mathieu-Daudé 1 week ago
On 5/18/20 6:58 PM, Paul Menzel wrote:
> Printing the return value of `scsi_is_ready()` is a debug message, so
> change the log level from 1 to 5.
> 
>      Booting from DVD/CD...
>      Device reports MEDIUM NOT PRESENT
>      scsi_is_ready returned -1
>      Boot failed: Could not read from CDROM (code 0003)
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>   src/cdrom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cdrom.c b/src/cdrom.c
> index 577d69d..a77671a 100644
> --- a/src/cdrom.c
> +++ b/src/cdrom.c
> @@ -142,7 +142,7 @@ cdrom_boot(struct drive_s *drive)
>   
>       int ret = scsi_is_ready(&dop);
>       if (ret)
> -        dprintf(1, "scsi_is_ready returned %d\n", ret);
> +        dprintf(5, "scsi_is_ready returned %d\n", ret);
>   
>       // Read the Boot Record Volume Descriptor
>       u8 buffer[CDROM_SECTOR_SIZE];
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org