[SeaBIOS] [PATCH 0/1] build: increase .version priority over git

Alexey Kirillov posted 1 patch 10 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20200121142606.12165-1-lekiravi@yandex-team.ru
scripts/buildversion.py | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)

[SeaBIOS] [PATCH 0/1] build: increase .version priority over git

Posted by Alexey Kirillov 10 weeks ago
Now there is no convenient way to set the version number
in the required format if we build SeaBIOS from the repository.
It is proposed first of all to get the version number from
the .version file if it exists, if it is absent, from git.
This approach will allow you to safely specify the version
manually and will not affect existing builds.

Alexey Kirillov (1):
  build: increase .version priority over git

 scripts/buildversion.py | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

-- 
2.17.1
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org

[SeaBIOS] Re: [PATCH 0/1] build: increase .version priority over git

Posted by Gerd Hoffmann 10 weeks ago
  Hi,

> This approach will allow you to safely specify the version
> manually and will not affect existing builds.

We don't want an easy way to override the version.  It's useful
to have the exact version in the logs for bug reports etc.

We might change the way the version string is built though.
For starters scripts/tarball.sh and scripts/buildversion.py
are not consistent, it makes sense to fix that.  For example
scripts/tarball.sh detects that a release tag is checked out
and generated a shorter version string without git hash
included then.

So, what exactly do you need?

cheers,
  Gerd
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org