vgasrc/cbvga.c | 80 ++++++---------------------------------------- vgasrc/svgamodes.c | 8 +++++ 2 files changed, 17 insertions(+), 71 deletions(-)
Hello, this is my attempt to address the review comments I got for v2: - Gerd pointed out that cbvesa should only use the modes where memmodel == MM_DIRECT. - Kevin noted that reading global variables need the GET_GLOBAL wrapper. (I would have expected that the compiler does the right thing here. Probably I'm still to wet behind the ears here :-) Note this is only compile tested. Uwe Kleine-König (2): cbvga: reuse svga modes definitions from svgamodes.c Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440 vgasrc/cbvga.c | 80 ++++++---------------------------------------- vgasrc/svgamodes.c | 8 +++++ 2 files changed, 17 insertions(+), 71 deletions(-) -- 2.20.1 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
On 7/31/19 5:51 PM, Uwe Kleine-König wrote: > Hello, > > this is my attempt to address the review comments I got for v2: > > - Gerd pointed out that cbvesa should only use the modes where memmodel > == MM_DIRECT. > > - Kevin noted that reading global variables need the GET_GLOBAL > wrapper. (I would have expected that the compiler does the right > thing here. Probably I'm still to wet behind the ears here :-) > > Note this is only compile tested. Is there anything I have to do here to get these patches merged? Best regards Uwe _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: > On 7/31/19 5:51 PM, Uwe Kleine-König wrote: > > Hello, > > > > this is my attempt to address the review comments I got for v2: > > > > - Gerd pointed out that cbvesa should only use the modes where memmodel > > == MM_DIRECT. > > > > - Kevin noted that reading global variables need the GET_GLOBAL > > wrapper. (I would have expected that the compiler does the right > > thing here. Probably I'm still to wet behind the ears here :-) > > > > Note this is only compile tested. > > Is there anything I have to do here to get these patches merged? The patches look fine to me. The commits should have a signed-off-by line though. Gerd - do you have any further comments on this? -Kevin _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
Hello Kevin,
On 10/13/19 4:07 AM, Kevin O'Connor wrote:
> The commits should have a signed-off-by
> line though.
Not sure what is meant here. Do you miss an S-o-b by me or by Gerd?
If the former and assuming the intention is that its meaning is similar
to that in the kernel: INAL, but I think if you want to have an at least
small chance that this formalism has any juristic meaning you need to
formalize it. Currently you ship GPLv3 and LGPLv3 in seabios.git but
many source files don't have their own copyright notes that declare
which should be effective[1]. Also there is no file that documents what
Signed-off-by should actually mean.
Just my 0.02€
Uwe
[1] I only checked a few files (vgasrc/ramfb.c, vgasrc/svgamodes.c) by
hand and assumed the other files to be in a similar situation. A quick
glance using licensecheck from
https://metacpan.org/release/App-Licensecheck:
seabios$ git ls-files | xargs licensecheck | sed "s/.*: //" | sort | uniq -c
2008 is > 1013 at /usr/share/perl5/String/Copyright.pm line 194.
1 BSD (2 clause)
10 GPL
4 GPL GENERATED FILE
16 GPL (v2.0)
1 GPL (v2) GENERATED FILE
102 LGPL (v3)
1 MIT/X11 (BSD like)
3 *No copyright* GENERATED FILE
1 *No copyright* GPL (v2.0)
7 *No copyright* GPL (v2 or later) (with incorrect FSF address)
3 *No copyright* LGPL (v3)
101 *No copyright* UNKNOWN
6 UNKNOWN
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-leave@seabios.org
On Sat, Oct 12, 2019 at 10:07:23PM -0400, Kevin O'Connor wrote: > On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: > > On 7/31/19 5:51 PM, Uwe Kleine-König wrote: > > > Hello, > > > > > > this is my attempt to address the review comments I got for v2: > > > > > > - Gerd pointed out that cbvesa should only use the modes where memmodel > > > == MM_DIRECT. > > > > > > - Kevin noted that reading global variables need the GET_GLOBAL > > > wrapper. (I would have expected that the compiler does the right > > > thing here. Probably I'm still to wet behind the ears here :-) > > > > > > Note this is only compile tested. > > > > Is there anything I have to do here to get these patches merged? > > The patches look fine to me. The commits should have a signed-off-by > line though. Gerd - do you have any further comments on this? No comments, looks all fine to me. cheers, Gerd _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
On 10/16/19 12:27 PM, Gerd Hoffmann wrote: > On Sat, Oct 12, 2019 at 10:07:23PM -0400, Kevin O'Connor wrote: >> On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: >>> On 7/31/19 5:51 PM, Uwe Kleine-König wrote: >>>> Hello, >>>> >>>> this is my attempt to address the review comments I got for v2: >>>> >>>> - Gerd pointed out that cbvesa should only use the modes where memmodel >>>> == MM_DIRECT. >>>> >>>> - Kevin noted that reading global variables need the GET_GLOBAL >>>> wrapper. (I would have expected that the compiler does the right >>>> thing here. Probably I'm still to wet behind the ears here :-) >>>> >>>> Note this is only compile tested. >>> >>> Is there anything I have to do here to get these patches merged? >> >> The patches look fine to me. The commits should have a signed-off-by >> line though. Gerd - do you have any further comments on this? > > No comments, looks all fine to me. Would it help if I prepared a pull-request for my patches? How else can I help getting these patches in? I'm still unclear about that Signed-of-by concern. Best regards Uwe _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
On Thu, Oct 17, 2019 at 09:44:38AM +0200, Uwe Kleine-König wrote: > On 10/16/19 12:27 PM, Gerd Hoffmann wrote: > > On Sat, Oct 12, 2019 at 10:07:23PM -0400, Kevin O'Connor wrote: > >> On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: > >>> On 7/31/19 5:51 PM, Uwe Kleine-König wrote: > >>>> Hello, > >>>> > >>>> this is my attempt to address the review comments I got for v2: > >>>> > >>>> - Gerd pointed out that cbvesa should only use the modes where memmodel > >>>> == MM_DIRECT. > >>>> > >>>> - Kevin noted that reading global variables need the GET_GLOBAL > >>>> wrapper. (I would have expected that the compiler does the right > >>>> thing here. Probably I'm still to wet behind the ears here :-) > >>>> > >>>> Note this is only compile tested. > >>> > >>> Is there anything I have to do here to get these patches merged? > >> > >> The patches look fine to me. The commits should have a signed-off-by > >> line though. Gerd - do you have any further comments on this? > > > > No comments, looks all fine to me. > > Would it help if I prepared a pull-request for my patches? How else can > I help getting these patches in? I'm still unclear about that > Signed-of-by concern. Re-send patches with Signed-of-by added to the commit message. Git can do that automatically for you (-s switch for "git commit"). It's used to keep track of the patch workflow (who wrote the patch, who reviewed & committed, ...). cheers, Gerd _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
On 10/17/19 10:51 AM, Gerd Hoffmann wrote: > On Thu, Oct 17, 2019 at 09:44:38AM +0200, Uwe Kleine-König wrote: >> I'm still unclear about that >> Signed-of-by concern. > > Re-send patches with Signed-of-by added to the commit message. Git can > do that automatically for you (-s switch for "git commit"). It's used > to keep track of the patch workflow (who wrote the patch, who reviewed & > committed, ...). I would have expected that the "who wrote" is obvious from the Author: line in the commit, "who reviewed" by something like "Reviewed-by:" and the committer from the Committer line. For the projects I usually interact with Signed-off-by has a juristic meaning, see my mail from Monday. If the Signed-off-by here really only has the purpose to show through which hands the patch went in, I can resend of course. Best regards Uwe _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
'signed-off-by' is a linux kernel convention; by adding your Signed-off-by line to a patch, you are certifying that you have read and understood the Developer Certificate of Origin (DCO), originated in 2004 by the Linux foundation as an affirmation that the source code being submitted originated from the developer, or that the developer has permission to submit the code. Many projects follow the same conventions used by the linux kernel. https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin On Thu, Oct 17, 2019 at 4:31 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote: > On 10/17/19 10:51 AM, Gerd Hoffmann wrote: > > On Thu, Oct 17, 2019 at 09:44:38AM +0200, Uwe Kleine-König wrote: > >> I'm still unclear about that > >> Signed-of-by concern. > > > > Re-send patches with Signed-of-by added to the commit message. Git can > > do that automatically for you (-s switch for "git commit"). It's used > > to keep track of the patch workflow (who wrote the patch, who reviewed & > > committed, ...). > > I would have expected that the "who wrote" is obvious from the Author: > line in the commit, "who reviewed" by something like "Reviewed-by:" and > the committer from the Committer line. > > For the projects I usually interact with Signed-off-by has a juristic > meaning, see my mail from Monday. > > If the Signed-off-by here really only has the purpose to show through > which hands the patch went in, I can resend of course. > > Best regards > Uwe > > _______________________________________________ > SeaBIOS mailing list -- seabios@seabios.org > To unsubscribe send an email to seabios-leave@seabios.org > _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org
© 2016 - 2023 Red Hat, Inc.