[SeaBIOS] [PATCH] pvscsi: Scan all 64 possible targets

Shmuel Eiderman posted 1 patch 41 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/seabios tags/patchew/20181101151442.99296-1-shmuel.eiderman@oracle.com
src/hw/pvscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[SeaBIOS] [PATCH] pvscsi: Scan all 64 possible targets

Posted by Shmuel Eiderman 41 weeks ago
The max number of targets per PVSCSI controller is 64, not 7.
This can easily be seen in QEMU PVSCSI emulation code
(hw/scsi/vmw_pvscsi.c) as PVSCSI_MAX_DEVS, which defines the
number of targets, have value of 64.

Fixes: 83d60b3c474b ("Add pvscsi boot support")

Reviewed-by: Liran Alon <liran.alon@oracle.com>
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
Signed-off-by: Shmuel Eiderman <shmuel.eiderman@oracle.com>
---
 src/hw/pvscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/pvscsi.c b/src/hw/pvscsi.c
index d62d0a0..e0ea33c 100644
--- a/src/hw/pvscsi.c
+++ b/src/hw/pvscsi.c
@@ -310,7 +310,7 @@ init_pvscsi(void *data)
     struct pvscsi_ring_dsc_s *ring_dsc = NULL;
     pvscsi_init_rings(iobase, &ring_dsc);
     int i;
-    for (i = 0; i < 7; i++)
+    for (i = 0; i < 64; i++)
         pvscsi_scan_target(pci, iobase, ring_dsc, i);
 }
 
-- 
2.16.1


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH] pvscsi: Scan all 64 possible targets

Posted by Kevin O'Connor 40 weeks ago
On Thu, Nov 01, 2018 at 05:14:42PM +0200, Shmuel Eiderman wrote:
> The max number of targets per PVSCSI controller is 64, not 7.
> This can easily be seen in QEMU PVSCSI emulation code
> (hw/scsi/vmw_pvscsi.c) as PVSCSI_MAX_DEVS, which defines the
> number of targets, have value of 64.

Thanks.  I committed this change.

-Kevin

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios