tpm: Request access to locality 0

[SeaBIOS] [PATCH] tpm: Request access to locality 0

Posted by Stefan Berger 6 years ago

The CRB driver has to request access to locality 0. Our QEMU
CRB model will enforce that as well.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
 src/hw/tpm_drivers.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c
index bd971f7..e4770b3 100644
--- a/src/hw/tpm_drivers.c
+++ b/src/hw/tpm_drivers.c
@@ -442,6 +442,8 @@ static u32 crb_activate(u8 locty)
     if (!CONFIG_TCGBIOS)
         return 0;
 
+    writeb(CRB_REG(locty, CRB_REG_LOC_CTRL), 1);
+
     return 0;
 }
 
-- 
2.5.5


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH] tpm: Request access to locality 0

Posted by Stefan Berger 6 years ago

On 03/28/2018 03:37 PM, Stefan Berger wrote:
> The CRB driver has to request access to locality 0. Our QEMU
> CRB model will enforce that as well.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

Kevin, can you please apply this patch.

    Stefan

> ---
>   src/hw/tpm_drivers.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c
> index bd971f7..e4770b3 100644
> --- a/src/hw/tpm_drivers.c
> +++ b/src/hw/tpm_drivers.c
> @@ -442,6 +442,8 @@ static u32 crb_activate(u8 locty)
>       if (!CONFIG_TCGBIOS)
>           return 0;
>
> +    writeb(CRB_REG(locty, CRB_REG_LOC_CTRL), 1);
> +
>       return 0;
>   }
>


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH] tpm: Request access to locality 0

Posted by Kevin O'Connor 6 years ago

On Thu, Apr 12, 2018 at 02:55:52PM -0400, Stefan Berger wrote:
> On 03/28/2018 03:37 PM, Stefan Berger wrote:
> > The CRB driver has to request access to locality 0. Our QEMU
> > CRB model will enforce that as well.
> > 
> > Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> 
> Kevin, can you please apply this patch.

Yes.  I've committed the patch.

Thanks.
-Kevin

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios