[v1] microvm: Enable hotplug of pcie

[PATCH] microvm: Enable hotplug of pcie

suyuheng posted 1 patch 3 years ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/tencent_F4EF5FC4638158CB96B434014DF9CBF62405@qq.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

There is a newer version of this series

hw/i386/acpi-microvm.c | 11 +++++++++++
1 file changed, 11 insertions(+)

Expand all Fold all

[PATCH] microvm: Enable hotplug of pcie

Posted by suyuheng 3 years ago

From: Yuheng Su <suyuheng@bytedance.com>

Signed-off-by: Yuheng Su <suyuheng@bytedance.com>
---
 hw/i386/acpi-microvm.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c
index ccd3303aac..4f32bf512f 100644
--- a/hw/i386/acpi-microvm.c
+++ b/hw/i386/acpi-microvm.c
@@ -26,6 +26,7 @@
 
 #include "exec/memory.h"
 #include "hw/acpi/acpi.h"
+#include "hw/acpi/pci.h"
 #include "hw/acpi/aml-build.h"
 #include "hw/acpi/bios-linker-loader.h"
 #include "hw/acpi/generic_event_device.h"
@@ -209,6 +210,16 @@ static void acpi_build_microvm(AcpiBuildTables *tables,
                     ACPI_DEVICE_IF(x86ms->acpi_dev), x86ms->oem_id,
                     x86ms->oem_table_id);
 
+    acpi_add_table(table_offsets, tables_blob);
+    {
+        AcpiMcfgInfo mcfg = {
+           .base = mms->gpex.ecam.base,
+           .size = mms->gpex.ecam.size,
+        };
+        build_mcfg(tables_blob, tables->linker, &mcfg, x86ms->oem_id,
+                   x86ms->oem_table_id);
+    }
+
     xsdt = tables_blob->len;
     build_xsdt(tables_blob, tables->linker, table_offsets, x86ms->oem_id,
                x86ms->oem_table_id);
-- 
2.11.0

Re: [PATCH] microvm: Enable hotplug of pcie

Posted by Michael S. Tsirkin 3 years ago

On Tue, Apr 27, 2021 at 09:04:27PM +0800, suyuheng wrote:
> From: Yuheng Su <suyuheng@bytedance.com>
> 
> Signed-off-by: Yuheng Su <suyuheng@bytedance.com>


seems to be extended config space as opposed to hotplug ...

> ---
>  hw/i386/acpi-microvm.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c
> index ccd3303aac..4f32bf512f 100644
> --- a/hw/i386/acpi-microvm.c
> +++ b/hw/i386/acpi-microvm.c
> @@ -26,6 +26,7 @@
>  
>  #include "exec/memory.h"
>  #include "hw/acpi/acpi.h"
> +#include "hw/acpi/pci.h"
>  #include "hw/acpi/aml-build.h"
>  #include "hw/acpi/bios-linker-loader.h"
>  #include "hw/acpi/generic_event_device.h"
> @@ -209,6 +210,16 @@ static void acpi_build_microvm(AcpiBuildTables *tables,
>                      ACPI_DEVICE_IF(x86ms->acpi_dev), x86ms->oem_id,
>                      x86ms->oem_table_id);
>  
> +    acpi_add_table(table_offsets, tables_blob);
> +    {
> +        AcpiMcfgInfo mcfg = {
> +           .base = mms->gpex.ecam.base,
> +           .size = mms->gpex.ecam.size,
> +        };
> +        build_mcfg(tables_blob, tables->linker, &mcfg, x86ms->oem_id,
> +                   x86ms->oem_table_id);
> +    }
> +
>      xsdt = tables_blob->len;
>      build_xsdt(tables_blob, tables->linker, table_offsets, x86ms->oem_id,
>                 x86ms->oem_table_id);
> -- 
> 2.11.0