util/readline.c: Add common but missing shortcuts

[PATCH v1 0/3] util/readline.c: Add common but missing shortcuts

Manos Pitsidianakis posted 3 patches 5 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/readline-shortcuts-v1.1718265822.manos.pitsidianakis@linaro.org

util/readline.c | 35 +++++++++++++++++++++++++++++++----
1 file changed, 31 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH v1 0/3] util/readline.c: Add common but missing shortcuts

Posted by Manos Pitsidianakis 5 months, 2 weeks ago

Some commonly used readline shortcuts are missing from our 
implementation. This series adds:

- Control-n next line, same as Down arrow key
- Control-p previous line, same as Up arrow key
- Control-u erase line starting from cursor

Manos Pitsidianakis (3):
  util/readline.c:fix lints for readline_handle_byte
  util/readline.c: add C-n, C-p shortcuts
  util/readline.c: add C-u shortcut

 util/readline.c | 35 +++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)


base-commit: f3e8cc47de2bc537d4991e883a85208e4e1c0f98
-- 
γαῖα πυρί μιχθήτω

Re: [PATCH v1 0/3] util/readline.c: Add common but missing shortcuts

Posted by Philippe Mathieu-Daudé 5 months, 1 week ago

On 13/6/24 10:06, Manos Pitsidianakis wrote:
> Some commonly used readline shortcuts are missing from our
> implementation. This series adds:
> 
> - Control-n next line, same as Down arrow key
> - Control-p previous line, same as Up arrow key
> - Control-u erase line starting from cursor
> 
> Manos Pitsidianakis (3):
>    util/readline.c:fix lints for readline_handle_byte
>    util/readline.c: add C-n, C-p shortcuts
>    util/readline.c: add C-u shortcut

Series queued, thanks.

Re: [PATCH v1 0/3] util/readline.c: Add common but missing shortcuts

Posted by Marc-André Lureau 5 months, 2 weeks ago

Hi

On Thu, Jun 13, 2024 at 12:07 PM Manos Pitsidianakis <
manos.pitsidianakis@linaro.org> wrote:

> Some commonly used readline shortcuts are missing from our
> implementation. This series adds:
>
> - Control-n next line, same as Down arrow key
> - Control-p previous line, same as Up arrow key
> - Control-u erase line starting from cursor
>
> Manos Pitsidianakis (3):
>   util/readline.c:fix lints for readline_handle_byte
>   util/readline.c: add C-n, C-p shortcuts
>   util/readline.c: add C-u shortcut
>
>  util/readline.c | 35 +++++++++++++++++++++++++++++++----
>  1 file changed, 31 insertions(+), 4 deletions(-)
>
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


-- 
Marc-André Lureau