Am 23.05.2026 um 08:49 hat Michael Tokarev geschrieben:
> On 23.05.2026 02:10, Fiona Ebner wrote:
> > Hi Michael,
> >
> > Am 22.05.26 um 11:35 PM schrieb Michael Tokarev:
> > > Please respond here or CC qemu-stable@nongnu.org on any additional patches
> > > you think should (or shouldn't) be included in the release.
> >
> > > 92 b8bfb1478d61 Kevin Wolf:
> > > qcow2: Fix corruption on discard during write with COW
> > > 93 389f5bcc744d Kevin Wolf:
> > > iotests/046: Test that discard/write_zeroes wait for dependencies
> >
> > since number 92 can cause an issue [0] that is much easier to run into
> > than the one it solves, but still similarly bad, I think it should only
> > be included together with Thomas' fix [1] on top. I know that one has
> > not been applied to master or reviewed by a maintainer yet, so if
> > including it goes against procedure, maybe it'd be better to leave 92
> > (and 93) out for now or delay the release?
> >
> > Same for the other stable series. Thank you for the consideration!
>
> Thank you very much for letting me know. Yes, it isn't good to include
> "Fix corruption on discard" without the follow-up fix. So it would be
> very nice to have the follow-up fix applied to the master branch today
> or tomorrow (this is Sat and Sun, maybe not the best timing), or I'll
> have to drop the above mentioned two changes from the stable series.
> Or indeed, releases should be delayed - in a hope the fix can be applied
> on Monday.
>
> I'll wait for some reaction. Kevin?
I was out yesterday and most of today, so I could only take a quick look
just now. The patch looks reasonable to me at first sight, I'll try to
have a closer look tomorrow.
Kevin