linux-user: fix TIOCGSID ioctl

[PATCH] linux-user: fix TIOCGSID ioctl

Andreas Schwab posted 1 patch 9 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/mvmtsvp9cpk.fsf@suse.de

Maintainers: Laurent Vivier <laurent@vivier.eu>, Pierrick Bouvier <pierrick.bouvier@linaro.org>

linux-user/ioctls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] linux-user: fix TIOCGSID ioctl

Posted by Andreas Schwab 9 hours ago

TIOCGSID is IOC_R, not IOC_W.

Signed-off-by: Andreas Schwab <schwab@suse.de>
---
 linux-user/ioctls.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
index 6ecfe6306e..5b7d00e92f 100644
--- a/linux-user/ioctls.h
+++ b/linux-user/ioctls.h
@@ -26,7 +26,7 @@
      IOCTL(TIOCSCTTY, 0, TYPE_INT)
      IOCTL(TIOCGPGRP, IOC_R, MK_PTR(TYPE_INT))
      IOCTL(TIOCSPGRP, IOC_W, MK_PTR(TYPE_INT))
-     IOCTL(TIOCGSID, IOC_W, MK_PTR(TYPE_INT))
+     IOCTL(TIOCGSID, IOC_R, MK_PTR(TYPE_INT))
      IOCTL(TIOCOUTQ, IOC_R, MK_PTR(TYPE_INT))
      IOCTL(TIOCSTI, IOC_W, MK_PTR(TYPE_INT))
      IOCTL(TIOCMGET, IOC_R, MK_PTR(TYPE_INT))
-- 
2.53.0


-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH] linux-user: fix TIOCGSID ioctl

Posted by Helge Deller 3 hours ago

On 2/10/26 10:20, Andreas Schwab wrote:
> TIOCGSID is IOC_R, not IOC_W.
> 
> Signed-off-by: Andreas Schwab <schwab@suse.de>

Reviewed-by: Helge Deller <deller@gmx.de>

Helge

> ---
>   linux-user/ioctls.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 6ecfe6306e..5b7d00e92f 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -26,7 +26,7 @@
>        IOCTL(TIOCSCTTY, 0, TYPE_INT)
>        IOCTL(TIOCGPGRP, IOC_R, MK_PTR(TYPE_INT))
>        IOCTL(TIOCSPGRP, IOC_W, MK_PTR(TYPE_INT))
> -     IOCTL(TIOCGSID, IOC_W, MK_PTR(TYPE_INT))
> +     IOCTL(TIOCGSID, IOC_R, MK_PTR(TYPE_INT))
>        IOCTL(TIOCOUTQ, IOC_R, MK_PTR(TYPE_INT))
>        IOCTL(TIOCSTI, IOC_W, MK_PTR(TYPE_INT))
>        IOCTL(TIOCMGET, IOC_R, MK_PTR(TYPE_INT))