[PATCH 2/5] hda-codec: fix recording rate control

Volker Rümelin posted 5 patches 5 years, 10 months ago
There is a newer version of this series
[PATCH 2/5] hda-codec: fix recording rate control
Posted by Volker Rümelin 5 years, 10 months ago
Apply previous commit to hda_audio_input_cb for the same
reasons.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 hw/audio/hda-codec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index 768ba31e79..e711a99a41 100644
--- a/hw/audio/hda-codec.c
+++ b/hw/audio/hda-codec.c
@@ -265,8 +265,6 @@ static void hda_audio_input_cb(void *opaque, int avail)
 
     int64_t to_transfer = MIN(B_SIZE - (wpos - rpos), avail);
 
-    hda_timer_sync_adjust(st, -((wpos - rpos) + to_transfer - (B_SIZE >> 1)));
-
     while (to_transfer) {
         uint32_t start = (uint32_t) (wpos & B_MASK);
         uint32_t chunk = (uint32_t) MIN(B_SIZE - start, to_transfer);
@@ -278,6 +276,8 @@ static void hda_audio_input_cb(void *opaque, int avail)
             break;
         }
     }
+
+    hda_timer_sync_adjust(st, -((wpos - rpos) - (B_SIZE >> 1)));
 }
 
 static void hda_audio_output_timer(void *opaque)
-- 
2.16.4

Re: [PATCH 2/5] hda-codec: fix recording rate control
Posted by Gerd Hoffmann 5 years, 10 months ago
On Thu, Dec 19, 2019 at 09:04:16PM +0100, Volker Rümelin wrote:
> Apply previous commit to hda_audio_input_cb for the same
> reasons.

This mail is multipart text+html and "git am" can't process it (the
others are text only).  Can you please resend the patches, preferably
with "git send-email" to avoid them being sent as multipart?  They all
look good to me (this series and the 6th patch sent as separate mail).

thanks,
  Gerd


Re: [PATCH 2/5] hda-codec: fix recording rate control
Posted by Volker Rümelin 5 years, 10 months ago
> This mail is multipart text+html and "git am" can't process it (the
> others are text only).  Can you please resend the patches, preferably
> with "git send-email" to avoid them being sent as multipart?  They all
> look good to me (this series and the 6th patch sent as separate mail).
>
>
Sorry, I made a mistake here. I will send a version 2 patch series with
git send-email.

With best regards,
Volker