Hi Gustavo,

>  From: Gustavo Romero <gustavo.romero@linaro.org>
>  Sent: Wednesday, August 28, 2024 9:36 PM
>  To: Salil Mehta <salil.mehta@huawei.com>; qemu-devel@nongnu.org;
>  qemu-arm@nongnu.org; mst@redhat.com
>  
>  Hi Salil,
>  
>  On 6/13/24 8:36 PM, Salil Mehta via wrote:
>  > PROLOGUE
>  > ========
>  >
>  > To assist in review and set the right expectations from this RFC,
>  > please first read the sections *APPENDED AT THE END* of this cover
>  letter:
>  >
>  > 1. Important *DISCLAIMER* [Section (X)] 2. Work presented at
>  KVMForum
>  > Conference (slides available) [Section (V)F] 3. Organization of
>  > patches [Section (XI)] 4. References [Section (XII)] 5. Detailed TODO
>  > list of leftover work or work-in-progress [Section (IX)]
>  >
>  > There has been interest shown by other organizations in adapting this
>  > series for their architecture. Hence, RFC V2 [21] has been split into
>  > architecture
>  > *agnostic* [22] and *specific* patch sets.
>  >
>  > This is an ARM architecture-specific patch set carved out of RFC V2.
>  > Please check section (XI)B for details of architecture agnostic patches.
>  >
>  > SECTIONS [I - XIII] are as follows:
>  >
>  > (I) Key Changes [details in last section (XIV)]
>  > ==============================================
>  >
>  > RFC V2 -> RFC V3
>  >

[...]

>  >
>  > (VI) Commands Used
>  > ==================
>  >
>  > A. Qemu launch commands to init the machine:
>  >
>  >      $ qemu-system-aarch64 --enable-kvm -machine virt,gic-version=3 \
>  >        -cpu host -smp cpus=4,maxcpus=6 \
>  >        -m 300M \
>  >        -kernel Image \
>  >        -initrd rootfs.cpio.gz \
>  >        -append "console=ttyAMA0 root=/dev/ram rdinit=/init maxcpus=2
>  acpi=force" \
>  >        -nographic \
>  >        -bios QEMU_EFI.fd \
>  >
>  > B. Hot-(un)plug related commands:
>  >
>  >    # Hotplug a host vCPU (accel=kvm):
>  >      $ device_add host-arm-cpu,id=core4,core-id=4
>  >
>  >    # Hotplug a vCPU (accel=tcg):
>  >      $ device_add cortex-a57-arm-cpu,id=core4,core-id=4
>  
>  Since support for hotplug is disabled on TCG, remove these two lines in v4
>  cover letter?


We are fixing that and it should be part of RFC V4.


Thanks
Salil.


>  
>  
>  Cheers,
>  Gustavo
>  
>  >    # Delete the vCPU:
>  >      $ device_del core4
>  >

[...]