virtiofsd: Add missing newline in error message

[PATCH] virtiofsd: Add missing newline in error message

Posted by Hubert Jasudowicz 2 years, 10 months ago

From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>

Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
---
 tools/virtiofsd/fuse_virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index fa4aff9b0e..fc2564a603 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se)
     dir = qemu_get_local_state_pathname("run/virtiofsd");
 
     if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
-        fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s",
+        fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",
                  __func__, dir, strerror(errno));
         return false;
     }
-- 
2.32.0

Re: [PATCH] virtiofsd: Add missing newline in error message

Posted by Philippe Mathieu-Daudé 2 years, 10 months ago

On 7/1/21 11:11 PM, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> 
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
>  tools/virtiofsd/fuse_virtio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] virtiofsd: Add missing newline in error message

Posted by Stefan Hajnoczi 2 years, 10 months ago

On Thu, Jul 01, 2021 at 11:11:48PM +0200, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> 
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
>  tools/virtiofsd/fuse_virtio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [PATCH] virtiofsd: Add missing newline in error message

Posted by Laurent Vivier 2 years, 10 months ago

Le 01/07/2021 à 23:11, Hubert Jasudowicz a écrit :
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> 
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
>  tools/virtiofsd/fuse_virtio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index fa4aff9b0e..fc2564a603 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se)
>      dir = qemu_get_local_state_pathname("run/virtiofsd");
>  
>      if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
> -        fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s",
> +        fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",
>                   __func__, dir, strerror(errno));
>          return false;
>      }
> 
Applied to my trivial-patches branch.

Thanks,
Laurent