[v2] ui/gtk: prevent QEMU lock up

[PATCH v2 0/1] ui/gtk: prevent QEMU lock up

Volker Rümelin posted 1 patch 2 years, 9 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/d06fa203-5a89-b454-8b01-8711aaafeea2@t-online.de

include/ui/gtk.h |  4 ++++
ui/gtk.c         | 42 +++++++++++++++++++++++++++++++++---------
2 files changed, 37 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH v2 0/1] ui/gtk: prevent QEMU lock up

Posted by Volker Rümelin 2 years, 9 months ago

Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple
characeters") it's very easy to lock up QEMU with the GTK ui.
If you configure a guest with a serial device and the guest
doesn't listen on this device, QEMU will lock up after
entering two characters in the serial console.

v2:
Gerd suggested to use the chr_accept_input() callback function
instead of a write retry timer and to drop patch 2/2.

Volker Rümelin (1):
   ui/gtk: add a keyboard fifo to the VTE consoles

  include/ui/gtk.h |  4 ++++
  ui/gtk.c         | 42 +++++++++++++++++++++++++++++++++---------
  2 files changed, 37 insertions(+), 9 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/1] ui/gtk: prevent QEMU lock up

Posted by Gerd Hoffmann 2 years, 9 months ago

  Hi,

> Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple
> characeters") it's very easy to lock up QEMU with the GTK ui.
> If you configure a guest with a serial device and the guest
> doesn't listen on this device, QEMU will lock up after
> entering two characters in the serial console.
> 
> v2:
> Gerd suggested to use the chr_accept_input() callback function
> instead of a write retry timer and to drop patch 2/2.

Very nice and easy to read patch now.

Queued up for 6.1.

thanks,
  Gerd