[PULL 0/1] dirtylimit improvement

infra.ai.cloud@bitdeer.com posted 1 patch 1 month, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1781095539.git.yong.huang@bitdeer.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Hyman Huang <infra.ai.cloud@bitdeer.com>
accel/kvm/kvm-all.c      | 42 ++++++++++++++++++++++++++++++++++------
accel/stubs/kvm-stub.c   |  4 ++++
include/system/kvm.h     |  7 +++++++
include/system/kvm_int.h |  3 +++
system/dirtylimit.c      |  2 ++
5 files changed, 52 insertions(+), 6 deletions(-)
[PULL 0/1] dirtylimit improvement
Posted by infra.ai.cloud@bitdeer.com 1 month, 2 weeks ago
From: Hyman Huang <yong.huang@bitdeer.com>

The following changes since commit de5d8bfd6105d3dd3ae668df9762df244a6d1506:

  Merge tag 'pull-loongarch-20260609' of https://github.com/gaosong715/qemu into staging (2026-06-09 14:00:28 -0400)

are available in the Git repository at:

  https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-pull-request-20260611

for you to fetch changes up to 3b224b1c7df1ddefd6bca34f201264d72846c397:

  accel/kvm: event-driven wakeup for dirty ring reaper thread (2026-06-11 08:22:50 +0800)

----------------------------------------------------------------
dirtylimit: refactor dirty ring reaper thread with event-driven wakeup

----------------------------------------------------------------
Bin Guo (1):
      accel/kvm: event-driven wakeup for dirty ring reaper thread

 accel/kvm/kvm-all.c      | 42 ++++++++++++++++++++++++++++++++++------
 accel/stubs/kvm-stub.c   |  4 ++++
 include/system/kvm.h     |  7 +++++++
 include/system/kvm_int.h |  3 +++
 system/dirtylimit.c      |  2 ++
 5 files changed, 52 insertions(+), 6 deletions(-)

-- 
2.43.0
Re: [PULL 0/1] dirtylimit improvement
Posted by Stefan Hajnoczi 1 month, 2 weeks ago
On Wed, Jun 10, 2026 at 9:15 PM <infra.ai.cloud@bitdeer.com> wrote:
>
> From: Hyman Huang <yong.huang@bitdeer.com>

Hi Hyman Huang,
Is this pull request intended for qemu.git/master?

I did not see any previous pull requests from you in QEMU's git log.
It looks like your previous dirtylimit work went through the migration
tree. Do you intend to start sending pull requests now and are the
migration maintainers aware?

Please follow the pull request process and sign your pull request with
your GPG key:
https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html

Thanks,
Stefan

>
> The following changes since commit de5d8bfd6105d3dd3ae668df9762df244a6d1506:
>
>   Merge tag 'pull-loongarch-20260609' of https://github.com/gaosong715/qemu into staging (2026-06-09 14:00:28 -0400)
>
> are available in the Git repository at:
>
>   https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-pull-request-20260611
>
> for you to fetch changes up to 3b224b1c7df1ddefd6bca34f201264d72846c397:
>
>   accel/kvm: event-driven wakeup for dirty ring reaper thread (2026-06-11 08:22:50 +0800)
>
> ----------------------------------------------------------------
> dirtylimit: refactor dirty ring reaper thread with event-driven wakeup
>
> ----------------------------------------------------------------
> Bin Guo (1):
>       accel/kvm: event-driven wakeup for dirty ring reaper thread
>
>  accel/kvm/kvm-all.c      | 42 ++++++++++++++++++++++++++++++++++------
>  accel/stubs/kvm-stub.c   |  4 ++++
>  include/system/kvm.h     |  7 +++++++
>  include/system/kvm_int.h |  3 +++
>  system/dirtylimit.c      |  2 ++
>  5 files changed, 52 insertions(+), 6 deletions(-)
>
> --
> 2.43.0
>
>
Re: [PULL 0/1] dirtylimit improvement
Posted by Hy Man 1 month, 2 weeks ago
On Thu, Jun 11, 2026 at 11:19 PM Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
> On Wed, Jun 10, 2026 at 9:15 PM <infra.ai.cloud@bitdeer.com> wrote:
> >
> > From: Hyman Huang <yong.huang@bitdeer.com>
>
> Hi Hyman Huang,
> Is this pull request intended for qemu.git/master?
>
> I did not see any previous pull requests from you in QEMU's git log.
> It looks like your previous dirtylimit work went through the migration
> tree. Do you intend to start sending pull requests now and are the
> migration maintainers aware?
>
> Please follow the pull request process and sign your pull request with
> your GPG key:
> https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html
>
> Thanks,
> Stefan

Thanks for the heads-up and suggestions. Let's wait for Paolo's reply. :)

>
> >
> > The following changes since commit de5d8bfd6105d3dd3ae668df9762df244a6d1506:
> >
> >   Merge tag 'pull-loongarch-20260609' of https://github.com/gaosong715/qemu into staging (2026-06-09 14:00:28 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-pull-request-20260611
> >
> > for you to fetch changes up to 3b224b1c7df1ddefd6bca34f201264d72846c397:
> >
> >   accel/kvm: event-driven wakeup for dirty ring reaper thread (2026-06-11 08:22:50 +0800)
> >
> > ----------------------------------------------------------------
> > dirtylimit: refactor dirty ring reaper thread with event-driven wakeup
> >
> > ----------------------------------------------------------------
> > Bin Guo (1):
> >       accel/kvm: event-driven wakeup for dirty ring reaper thread
> >
> >  accel/kvm/kvm-all.c      | 42 ++++++++++++++++++++++++++++++++++------
> >  accel/stubs/kvm-stub.c   |  4 ++++
> >  include/system/kvm.h     |  7 +++++++
> >  include/system/kvm_int.h |  3 +++
> >  system/dirtylimit.c      |  2 ++
> >  5 files changed, 52 insertions(+), 6 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
Re: [PULL 0/1] dirtylimit improvement
Posted by Peter Xu 1 month, 2 weeks ago
On Thu, Jun 11, 2026 at 11:18:53AM -0400, Stefan Hajnoczi wrote:
> On Wed, Jun 10, 2026 at 9:15 PM <infra.ai.cloud@bitdeer.com> wrote:
> >
> > From: Hyman Huang <yong.huang@bitdeer.com>
> 
> Hi Hyman Huang,
> Is this pull request intended for qemu.git/master?
> 
> I did not see any previous pull requests from you in QEMU's git log.
> It looks like your previous dirtylimit work went through the migration
> tree. Do you intend to start sending pull requests now and are the
> migration maintainers aware?

We're not..

Since dirtylimit is almost only used with migration, Hyman, do you want us
to keep sending pulls for you?  I think it's better we're copied on all
these changes at the very minimum.

The other thing about the pull I want to say is, that patch changed most on
KVM not dirtylimit: v2 sent on June 4th and planned to be merged today
without maintainer's ACK (in this case Paolo, I added into the loop), I
think that's a bit too rush.  Shall we still at least give Paolo some time
in case he wants to say something?

Paolo might be busy and may respond slow, normally what I do is keep
pinging if the patch is important; if not, I leave a patch there until it
becomes more important..  I suggest we do the same for this patch rather
than merging it without Paolo even noticing.

Logically the bare minimum is that patch gets an A-b from Paolo to merge
it.

Thanks,

> 
> Please follow the pull request process and sign your pull request with
> your GPG key:
> https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html
> 
> Thanks,
> Stefan
> 
> >
> > The following changes since commit de5d8bfd6105d3dd3ae668df9762df244a6d1506:
> >
> >   Merge tag 'pull-loongarch-20260609' of https://github.com/gaosong715/qemu into staging (2026-06-09 14:00:28 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-pull-request-20260611
> >
> > for you to fetch changes up to 3b224b1c7df1ddefd6bca34f201264d72846c397:
> >
> >   accel/kvm: event-driven wakeup for dirty ring reaper thread (2026-06-11 08:22:50 +0800)
> >
> > ----------------------------------------------------------------
> > dirtylimit: refactor dirty ring reaper thread with event-driven wakeup
> >
> > ----------------------------------------------------------------
> > Bin Guo (1):
> >       accel/kvm: event-driven wakeup for dirty ring reaper thread
> >
> >  accel/kvm/kvm-all.c      | 42 ++++++++++++++++++++++++++++++++++------
> >  accel/stubs/kvm-stub.c   |  4 ++++
> >  include/system/kvm.h     |  7 +++++++
> >  include/system/kvm_int.h |  3 +++
> >  system/dirtylimit.c      |  2 ++
> >  5 files changed, 52 insertions(+), 6 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
> 

-- 
Peter Xu


Re: [PULL 0/1] dirtylimit improvement
Posted by Hy Man 1 month, 2 weeks ago
Agreed!

On Fri, Jun 12, 2026 at 12:22 AM Peter Xu <peterx@redhat.com> wrote:
>
> On Thu, Jun 11, 2026 at 11:18:53AM -0400, Stefan Hajnoczi wrote:
> > On Wed, Jun 10, 2026 at 9:15 PM <infra.ai.cloud@bitdeer.com> wrote:
> > >
> > > From: Hyman Huang <yong.huang@bitdeer.com>
> >
> > Hi Hyman Huang,
> > Is this pull request intended for qemu.git/master?
> >
> > I did not see any previous pull requests from you in QEMU's git log.
> > It looks like your previous dirtylimit work went through the migration
> > tree. Do you intend to start sending pull requests now and are the
> > migration maintainers aware?
>
> We're not..
>
> Since dirtylimit is almost only used with migration, Hyman, do you want us
> to keep sending pulls for you?  I think it's better we're copied on all
> these changes at the very minimum.
>
> The other thing about the pull I want to say is, that patch changed most on
> KVM not dirtylimit: v2 sent on June 4th and planned to be merged today
> without maintainer's ACK (in this case Paolo, I added into the loop), I
> think that's a bit too rush.  Shall we still at least give Paolo some time
> in case he wants to say something?
>
> Paolo might be busy and may respond slow, normally what I do is keep
> pinging if the patch is important; if not, I leave a patch there until it
> becomes more important..  I suggest we do the same for this patch rather
> than merging it without Paolo even noticing.
>
> Logically the bare minimum is that patch gets an A-b from Paolo to merge
> it.
>
> Thanks,
>
> >
> > Please follow the pull request process and sign your pull request with
> > your GPG key:
> > https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html
> >
> > Thanks,
> > Stefan
> >
> > >
> > > The following changes since commit de5d8bfd6105d3dd3ae668df9762df244a6d1506:
> > >
> > >   Merge tag 'pull-loongarch-20260609' of https://github.com/gaosong715/qemu into staging (2026-06-09 14:00:28 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-pull-request-20260611
> > >
> > > for you to fetch changes up to 3b224b1c7df1ddefd6bca34f201264d72846c397:
> > >
> > >   accel/kvm: event-driven wakeup for dirty ring reaper thread (2026-06-11 08:22:50 +0800)
> > >
> > > ----------------------------------------------------------------
> > > dirtylimit: refactor dirty ring reaper thread with event-driven wakeup
> > >
> > > ----------------------------------------------------------------
> > > Bin Guo (1):
> > >       accel/kvm: event-driven wakeup for dirty ring reaper thread
> > >
> > >  accel/kvm/kvm-all.c      | 42 ++++++++++++++++++++++++++++++++++------
> > >  accel/stubs/kvm-stub.c   |  4 ++++
> > >  include/system/kvm.h     |  7 +++++++
> > >  include/system/kvm_int.h |  3 +++
> > >  system/dirtylimit.c      |  2 ++
> > >  5 files changed, 52 insertions(+), 6 deletions(-)
> > >
> > > --
> > > 2.43.0
> > >
> > >
> >
>
> --
> Peter Xu
>