[v12] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering

[PATCH v12 0/9] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering

Posted by BALATON Zoltan 2 weeks, 4 days ago

Changes from v11:
- Drop already merged patches in [PULL 00/49] Misc HW patches for 2026-03-08
Based-on: 20260308223433.25503-1-philmd@linaro.org
- Fix build without pixman

Chad Jablonski (9):
  ati-vga: Remove src and dst stride mutation in ati_2d_blt
  ati-vga: Use local variables for register values in ati_2d_blt
  ati-vga: Introduce ATI2DCtx struct for 2D blit context
  ati-vga: Extract setup_2d_blt_ctx from ati_2d_blt
  ati-vga: Split ati_2d_do_blt from ati_2d_blt
  ati-vga: Remove ATIVGAState param from ati_2d_do_blt
  ati-vga: Implement scissor rectangle clipping for 2D operations
  ati-vga: Implement HOST_DATA register writes
  ati-vga: Implement HOST_DATA flush to VRAM

 hw/display/ati.c      |  24 +++
 hw/display/ati_2d.c   | 438 ++++++++++++++++++++++++++++++------------
 hw/display/ati_dbg.c  |   9 +
 hw/display/ati_int.h  |  12 ++
 hw/display/ati_regs.h |  13 ++
 5 files changed, 378 insertions(+), 118 deletions(-)

-- 
2.41.3

Re: [PATCH v12 0/9] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering

Posted by Chad Jablonski 2 weeks, 4 days ago

Thanks Zoltan! You beat me to it. This fix looks good to me. And thank
you Philippe for picking this up.

Re: [PATCH v12 0/9] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering

Posted by Philippe Mathieu-Daudé 2 weeks, 3 days ago

On 9/3/26 02:47, BALATON Zoltan wrote:
> Changes from v11:
> - Drop already merged patches in [PULL 00/49] Misc HW patches for 2026-03-08
> Based-on: 20260308223433.25503-1-philmd@linaro.org

This didn't apply on this tag:

Applying: ati-vga: Remove src and dst stride mutation in ati_2d_blt
Applying: ati-vga: Use local variables for register values in ati_2d_blt
Applying: ati-vga: Introduce ATI2DCtx struct for 2D blit context
Patch failed at 0003 ati-vga: Introduce ATI2DCtx struct for 2D blit context
error: patch failed: hw/display/ati_2d.c:43
error: hw/display/ati_2d.c: patch does not apply

But I figured it out (minor checkpatch change).

Series queued, thanks.

> - Fix build without pixman
> 
> Chad Jablonski (9):
>    ati-vga: Remove src and dst stride mutation in ati_2d_blt
>    ati-vga: Use local variables for register values in ati_2d_blt
>    ati-vga: Introduce ATI2DCtx struct for 2D blit context
>    ati-vga: Extract setup_2d_blt_ctx from ati_2d_blt
>    ati-vga: Split ati_2d_do_blt from ati_2d_blt
>    ati-vga: Remove ATIVGAState param from ati_2d_do_blt
>    ati-vga: Implement scissor rectangle clipping for 2D operations
>    ati-vga: Implement HOST_DATA register writes
>    ati-vga: Implement HOST_DATA flush to VRAM

Re: [PATCH v12 0/9] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering

Posted by BALATON Zoltan 2 weeks, 3 days ago

On Mon, 9 Mar 2026, Philippe Mathieu-Daudé wrote:
> On 9/3/26 02:47, BALATON Zoltan wrote:
>> Changes from v11:
>> - Drop already merged patches in [PULL 00/49] Misc HW patches for 
>> 2026-03-08
>> Based-on: 20260308223433.25503-1-philmd@linaro.org
>
> This didn't apply on this tag:
>
> Applying: ati-vga: Remove src and dst stride mutation in ati_2d_blt
> Applying: ati-vga: Use local variables for register values in ati_2d_blt
> Applying: ati-vga: Introduce ATI2DCtx struct for 2D blit context
> Patch failed at 0003 ati-vga: Introduce ATI2DCtx struct for 2D blit context
> error: patch failed: hw/display/ati_2d.c:43
> error: hw/display/ati_2d.c: patch does not apply
>
> But I figured it out (minor checkpatch change).

Checkpatch did not complain to me before but there seem to have been a 
white space change in you pull request. I noticed that now and sent v13 
for that patch but looks like you were faster. Thanks a lot again for your 
help.

> Series queued, thanks.
>
>> - Fix build without pixman
>> 
>> Chad Jablonski (9):
>>    ati-vga: Remove src and dst stride mutation in ati_2d_blt
>>    ati-vga: Use local variables for register values in ati_2d_blt
>>    ati-vga: Introduce ATI2DCtx struct for 2D blit context
>>    ati-vga: Extract setup_2d_blt_ctx from ati_2d_blt
>>    ati-vga: Split ati_2d_do_blt from ati_2d_blt
>>    ati-vga: Remove ATIVGAState param from ati_2d_do_blt
>>    ati-vga: Implement scissor rectangle clipping for 2D operations
>>    ati-vga: Implement HOST_DATA register writes
>>    ati-vga: Implement HOST_DATA flush to VRAM

There was the other two patch series to fix guest_hwcursor will you queue 
that too?

Regards,
BALATON Zoltan

Re: [PATCH v12 0/9] ati-vga: Implement HOST_DATA transfers to enable X.org text rendering

Posted by Philippe Mathieu-Daudé 2 weeks, 3 days ago

On 9/3/26 14:13, BALATON Zoltan wrote:
> On Mon, 9 Mar 2026, Philippe Mathieu-Daudé wrote:
>> On 9/3/26 02:47, BALATON Zoltan wrote:
>>> Changes from v11:
>>> - Drop already merged patches in [PULL 00/49] Misc HW patches for 
>>> 2026-03-08
>>> Based-on: 20260308223433.25503-1-philmd@linaro.org
>>
>> This didn't apply on this tag:
>>
>> Applying: ati-vga: Remove src and dst stride mutation in ati_2d_blt
>> Applying: ati-vga: Use local variables for register values in ati_2d_blt
>> Applying: ati-vga: Introduce ATI2DCtx struct for 2D blit context
>> Patch failed at 0003 ati-vga: Introduce ATI2DCtx struct for 2D blit 
>> context
>> error: patch failed: hw/display/ati_2d.c:43
>> error: hw/display/ati_2d.c: patch does not apply
>>
>> But I figured it out (minor checkpatch change).
> 
> Checkpatch did not complain to me before but there seem to have been a 
> white space change in you pull request. I noticed that now and sent v13 
> for that patch but looks like you were faster. Thanks a lot again for 
> your help.

The errors were:

46/57 Checking commit 7ebf5e5ac2ad (ati-vga: Consolidate dirty region 
tracking in ati_2d_blt)
ERROR: "foo * bar" should be "foo *bar"
#38: FILE: hw/display/ati_2d.c:59:
+                                s->regs.dst_offset + dst_y * 
surface_stride(ds),

48/57 Checking commit 360cf823d841 (ati-vga: Use local variables for 
register values in ati_2d_blt)
ERROR: suspect code indent for conditional statements (8, 8)
#196: FILE: hw/display/ati_2d.c:212:
+        if (!use_pixman_fill ||
[...]
          {

I marked the first one as spurious, and am going to ignore the
second (some refactor could avoid the #ifdef'ry, but no time for
that change before the soft-freeze).

> 
>> Series queued, thanks.
>>
>>> - Fix build without pixman
>>>
>>> Chad Jablonski (9):
>>>    ati-vga: Remove src and dst stride mutation in ati_2d_blt
>>>    ati-vga: Use local variables for register values in ati_2d_blt
>>>    ati-vga: Introduce ATI2DCtx struct for 2D blit context
>>>    ati-vga: Extract setup_2d_blt_ctx from ati_2d_blt
>>>    ati-vga: Split ati_2d_do_blt from ati_2d_blt
>>>    ati-vga: Remove ATIVGAState param from ati_2d_do_blt
>>>    ati-vga: Implement scissor rectangle clipping for 2D operations
>>>    ati-vga: Implement HOST_DATA register writes
>>>    ati-vga: Implement HOST_DATA flush to VRAM
> 
> There was the other two patch series to fix guest_hwcursor will you 
> queue that too?

Yep!