[PATCH v9 0/8] memory: Remove most _nomigrate variants

BALATON Zoltan posted 8 patches 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1772802886.git.balaton@eik.bme.hu
Maintainers: Pierrick Bouvier <pierrick.bouvier@linaro.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Gerd Hoffmann <kraxel@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>
There is a newer version of this series
docs/devel/memory.rst                         |   9 +-
hw/display/cg3.c                              |   5 +-
hw/display/tcx.c                              |   8 +-
hw/display/vga.c                              |   4 +-
hw/sparc/sun4m.c                              |  19 +-
hw/sparc64/sun4u.c                            |  10 +-
hw/xtensa/xtfpga.c                            |   3 +-
include/system/memory.h                       |  49 ----
.../memory-region-housekeeping.cocci          |  47 ---
system/memory.c                               | 275 ++++++------------
10 files changed, 105 insertions(+), 324 deletions(-)
[PATCH v9 0/8] memory: Remove most _nomigrate variants
Posted by BALATON Zoltan 1 month, 1 week ago
v9:
- call qemu_ram_alloc after memory_region_init (Akihiko)
- add R-b tag to xtfpga patch

v8:
- reorganise patches to move simpler ones earlier
- drop error_propagate as suggested by Akihiko Odaki to follow current
  recommendations and so we don't need local err and don't have to
  pass errp to helper function

v7:
- convert xtfpga from global vmstate; this leaves just the vga usage
  of memory_region_init_ram_nomigrate so the >1 use is not anymore an
  argument therefore remove memory_region_init_ram_nomigrate too
- drop memory_region_error_propagate() until we can agree on what to
  do with it

v6:
- keep the last two uses of memory_region_init_ram_nomigrate in vga and xtfpga for now
- added R-b tags

v5:
- convert Sun machines and their display devices from global vmstate

v4:
- separate patch converting Sun machines from memory_region_init_ram_nomigrate
- split helper to init ram into two functions: setup and error_propagate
- also use memory_region_init_io in memory_region_init_ram_device_ptr

v3:
- rebased on master after some patches were merged
- drop some more line from memory-region-housekeeping.cocci
- added comment to explain what factored out helper does
- some more clean ups included

BALATON Zoltan (8):
  hw/display/{cg3.tcx}: Do not use memory_region_init_rom_nomigrate()
  memory: Remove memory_region_init_rom_nomigrate()
  sun4m,sun4u,tcx: Do not use memory_region_init_ram_nomigrate()
  hw/xtensa/xtfpga:  Do not use memory_region_init_ram_nomigrate()
  memory: Remove memory_region_init_ram_nomigrate()
  memory: Shorten memory_region_init_ram_device_ptr and
    memory_region_init_rom_device
  memory: Add internal memory_region_register_ram function
  memory: Factor out common ram region initialization

 docs/devel/memory.rst                         |   9 +-
 hw/display/cg3.c                              |   5 +-
 hw/display/tcx.c                              |   8 +-
 hw/display/vga.c                              |   4 +-
 hw/sparc/sun4m.c                              |  19 +-
 hw/sparc64/sun4u.c                            |  10 +-
 hw/xtensa/xtfpga.c                            |   3 +-
 include/system/memory.h                       |  49 ----
 .../memory-region-housekeeping.cocci          |  47 ---
 system/memory.c                               | 275 ++++++------------
 10 files changed, 105 insertions(+), 324 deletions(-)

-- 
2.41.3
Re: [PATCH v9 0/8] memory: Remove most _nomigrate variants
Posted by Akihiko Odaki 1 month, 1 week ago
On 2026/03/06 22:19, BALATON Zoltan wrote:
> v9:
> - call qemu_ram_alloc after memory_region_init (Akihiko)

It now looks good to me now.

For the entire patch series:

Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>

> - add R-b tag to xtfpga patch
> 
> v8:
> - reorganise patches to move simpler ones earlier
> - drop error_propagate as suggested by Akihiko Odaki to follow current
>    recommendations and so we don't need local err and don't have to
>    pass errp to helper function
> 
> v7:
> - convert xtfpga from global vmstate; this leaves just the vga usage
>    of memory_region_init_ram_nomigrate so the >1 use is not anymore an
>    argument therefore remove memory_region_init_ram_nomigrate too
> - drop memory_region_error_propagate() until we can agree on what to
>    do with it
> 
> v6:
> - keep the last two uses of memory_region_init_ram_nomigrate in vga and xtfpga for now
> - added R-b tags
> 
> v5:
> - convert Sun machines and their display devices from global vmstate
> 
> v4:
> - separate patch converting Sun machines from memory_region_init_ram_nomigrate
> - split helper to init ram into two functions: setup and error_propagate
> - also use memory_region_init_io in memory_region_init_ram_device_ptr
> 
> v3:
> - rebased on master after some patches were merged
> - drop some more line from memory-region-housekeeping.cocci
> - added comment to explain what factored out helper does
> - some more clean ups included
> 
> BALATON Zoltan (8):
>    hw/display/{cg3.tcx}: Do not use memory_region_init_rom_nomigrate()
>    memory: Remove memory_region_init_rom_nomigrate()
>    sun4m,sun4u,tcx: Do not use memory_region_init_ram_nomigrate()
>    hw/xtensa/xtfpga:  Do not use memory_region_init_ram_nomigrate()
>    memory: Remove memory_region_init_ram_nomigrate()
>    memory: Shorten memory_region_init_ram_device_ptr and
>      memory_region_init_rom_device
>    memory: Add internal memory_region_register_ram function
>    memory: Factor out common ram region initialization
> 
>   docs/devel/memory.rst                         |   9 +-
>   hw/display/cg3.c                              |   5 +-
>   hw/display/tcx.c                              |   8 +-
>   hw/display/vga.c                              |   4 +-
>   hw/sparc/sun4m.c                              |  19 +-
>   hw/sparc64/sun4u.c                            |  10 +-
>   hw/xtensa/xtfpga.c                            |   3 +-
>   include/system/memory.h                       |  49 ----
>   .../memory-region-housekeeping.cocci          |  47 ---
>   system/memory.c                               | 275 ++++++------------
>   10 files changed, 105 insertions(+), 324 deletions(-)
>