[v8] memory: Remove most _nomigrate variants

[PATCH v8 4/8] hw/xtensa/xtfpga: Do not use memory_region_init_ram_nomigrate()

BALATON Zoltan posted 8 patches 1 month ago

Diff against v1 v2 v3 v4 v5 v6 v7 v9 v10
Download mbox

Maintainers: Pierrick Bouvier <pierrick.bouvier@linaro.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Gerd Hoffmann <kraxel@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

There is a newer version of this series

Expand all Fold all

[PATCH v8 4/8] hw/xtensa/xtfpga: Do not use memory_region_init_ram_nomigrate()

Posted by BALATON Zoltan 1 month ago

Convert to use memory_region_init_ram() instead. This breaks migration
but the machines using this device have no migration compatibility
guarantee.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/xtensa/xtfpga.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c
index d427d68e50..d40fccf9e5 100644
--- a/hw/xtensa/xtfpga.c
+++ b/hw/xtensa/xtfpga.c
@@ -163,9 +163,8 @@ static void xtfpga_net_init(MemoryRegion *address_space,
             sysbus_mmio_get_region(s, 1));
 
     ram = g_malloc(sizeof(*ram));
-    memory_region_init_ram_nomigrate(ram, OBJECT(s), "open_eth.ram", 16 * KiB,
+    memory_region_init_ram(ram, OBJECT(s), "open_eth.ram", 16 * KiB,
                            &error_fatal);
-    vmstate_register_ram_global(ram);
     memory_region_add_subregion(address_space, buffers, ram);
 }
 
-- 
2.41.3

Re: [PATCH v8 4/8] hw/xtensa/xtfpga: Do not use memory_region_init_ram_nomigrate()

Posted by Peter Maydell 1 month ago

On Fri, 6 Mar 2026 at 01:40, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> Convert to use memory_region_init_ram() instead. This breaks migration
> but the machines using this device have no migration compatibility
> guarantee.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/xtensa/xtfpga.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM