When used inside a loop, it is useful to have a return code to indicate
whether a send cper command succedded or not.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
scripts/qmp_helper.py | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/scripts/qmp_helper.py b/scripts/qmp_helper.py
index c1e7e0fd80ce..249a8c7187d1 100755
--- a/scripts/qmp_helper.py
+++ b/scripts/qmp_helper.py
@@ -531,7 +531,11 @@ def __init__(self, host, port, debug=False):
# Socket QMP send command
#
def send_cper_raw(self, cper_data):
- """Send a raw CPER data to QEMU though QMP TCP socket"""
+ """
+ Send a raw CPER data to QEMU though QMP TCP socket.
+
+ Return True on success, False otherwise.
+ """
data = b64encode(bytes(cper_data)).decode('ascii')
@@ -543,9 +547,16 @@ def send_cper_raw(self, cper_data):
if self.send_cmd("inject-ghes-v2-error", cmd_arg):
print("Error injected.")
+ return True
+
+ return False
def send_cper(self, notif_type, payload):
- """Send commands to QEMU though QMP TCP socket"""
+ """
+ Send commands to QEMU though QMP TCP socket.
+
+ Return True on success, False otherwise.
+ """
# Fill CPER record header
@@ -599,8 +610,7 @@ def send_cper(self, notif_type, payload):
util.dump_bytearray("Payload", payload)
- self.send_cper_raw(cper_data)
-
+ return self.send_cper_raw(cper_data)
def search_qom(self, path, prop, regex):
"""
--
2.52.0