contrib/plugins/hotblocks.c | 20 ++++++++++++++------ docs/about/emulation.rst | 12 ++++++++++++ 2 files changed, 26 insertions(+), 6 deletions(-)
This is a resend of my previous patchset which unfortunately seems not to have
been applied (see
<https://lore.kernel.org/qemu-devel/cover.1753857212.git.asb@igalia.com/).
I've rebased on current HEAD, checked it works as expected, and added
Reviewed-by tags to the patches, which all received review.
Repeating the summary from last time:
This series contains one minor feature addition and a series of small
bugfixes/improvements. The addition that motivates the submission is to add a
limit argument for the hotblocks plugin, allowing you to control how many
blocks are printed rather than being hardcoded to the 20 most executed.
Setting limit=0 and dumping information about all executed blocks is
incredibly helpful for an analysis script I have downstream.
This is my first contribution to QEMU. I've attempted to follow all of the
guidance in the "Submitting a Patch" guide, but apologies if I missed
anything.
Alex Bradbury (5):
contrib/plugins/hotblocks: Correctly free sorted counts list
contrib/plugins/hotblocks: Fix off by one error in iteration of sorted
blocks
contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than
PRId64
docs/about/emulation: Add documentation for hotblocks plugin arguments
contrib/plugins/hotblocks: Allow limit to be set as a command line
argument
contrib/plugins/hotblocks.c | 20 ++++++++++++++------
docs/about/emulation.rst | 12 ++++++++++++
2 files changed, 26 insertions(+), 6 deletions(-)
--
2.52.0
Alex Bradbury <asb@igalia.com> writes: > This is a resend of my previous patchset which unfortunately seems not to have > been applied (see > <https://lore.kernel.org/qemu-devel/cover.1753857212.git.asb@igalia.com/). > I've rebased on current HEAD, checked it works as expected, and added > Reviewed-by tags to the patches, which all received review. Queued to plugins/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro
On 2025-12-02 23:05, Alex Bradbury wrote: > This is a resend of my previous patchset which unfortunately seems not to have > been applied (see > <https://lore.kernel.org/qemu-devel/cover.1753857212.git.asb@igalia.com/). > I've rebased on current HEAD, checked it works as expected, and added > Reviewed-by tags to the patches, which all received review. > > Repeating the summary from last time: > > This series contains one minor feature addition and a series of small > bugfixes/improvements. The addition that motivates the submission is to add a > limit argument for the hotblocks plugin, allowing you to control how many > blocks are printed rather than being hardcoded to the 20 most executed. > Setting limit=0 and dumping information about all executed blocks is > incredibly helpful for an analysis script I have downstream. > > This is my first contribution to QEMU. I've attempted to follow all of the > guidance in the "Submitting a Patch" guide, but apologies if I missed > anything. > > Alex Bradbury (5): > contrib/plugins/hotblocks: Correctly free sorted counts list > contrib/plugins/hotblocks: Fix off by one error in iteration of sorted > blocks > contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than > PRId64 > docs/about/emulation: Add documentation for hotblocks plugin arguments > contrib/plugins/hotblocks: Allow limit to be set as a command line > argument > > contrib/plugins/hotblocks.c | 20 ++++++++++++++------ > docs/about/emulation.rst | 12 ++++++++++++ > 2 files changed, 26 insertions(+), 6 deletions(-) Sending a ping as per the guidance at <https://www.qemu.org/docs/master/devel/submitting-a-patch.html#if-your-patch-seems-to-have-been-ignored>, and also linking to the patch on lore.kernel.org as that page suggests <https://lore.kernel.org/qemu-devel/cover.1764716538.git.asb@igalia.com/> Thanks. Alex
Alex Bradbury <asb@igalia.com> writes: > On 2025-12-02 23:05, Alex Bradbury wrote: >> This is a resend of my previous patchset which unfortunately seems not to have >> been applied (see >> <https://lore.kernel.org/qemu-devel/cover.1753857212.git.asb@igalia.com/). >> I've rebased on current HEAD, checked it works as expected, and added >> Reviewed-by tags to the patches, which all received review. >> >> Repeating the summary from last time: >> >> This series contains one minor feature addition and a series of small >> bugfixes/improvements. The addition that motivates the submission is to add a >> limit argument for the hotblocks plugin, allowing you to control how many >> blocks are printed rather than being hardcoded to the 20 most executed. >> Setting limit=0 and dumping information about all executed blocks is >> incredibly helpful for an analysis script I have downstream. >> >> This is my first contribution to QEMU. I've attempted to follow all of the >> guidance in the "Submitting a Patch" guide, but apologies if I missed >> anything. >> >> Alex Bradbury (5): >> contrib/plugins/hotblocks: Correctly free sorted counts list >> contrib/plugins/hotblocks: Fix off by one error in iteration of sorted >> blocks >> contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than >> PRId64 >> docs/about/emulation: Add documentation for hotblocks plugin arguments >> contrib/plugins/hotblocks: Allow limit to be set as a command line >> argument >> >> contrib/plugins/hotblocks.c | 20 ++++++++++++++------ >> docs/about/emulation.rst | 12 ++++++++++++ >> 2 files changed, 26 insertions(+), 6 deletions(-) > > Sending a ping as per the guidance at > <https://www.qemu.org/docs/master/devel/submitting-a-patch.html#if-your-patch-seems-to-have-been-ignored>, > and also linking to the patch on lore.kernel.org as that page suggests > <https://lore.kernel.org/qemu-devel/cover.1764716538.git.asb@igalia.com/> Sorry I missed this in v1. As we are getting very close to 10.2 getting out of the door I'll punt this until the tree re-opens. I have it on my backlog now. If you want I can also cc qemu-stable if you think its worth having the cleanups in 10.2.1 > > Thanks. > > Alex -- Alex Bennée Virtualisation Tech Lead @ Linaro
On 12/2/25 3:05 PM, Alex Bradbury wrote: > This is a resend of my previous patchset which unfortunately seems not to have > been applied (see > <https://lore.kernel.org/qemu-devel/cover.1753857212.git.asb@igalia.com/). > I've rebased on current HEAD, checked it works as expected, and added > Reviewed-by tags to the patches, which all received review. > Sorry about this, this unfortunately happens with email based development. @alex.bennee, is that still on time to merge this for next rc? The changes are trivial, and located in this plugin file only. Regards, Pierrick
© 2016 - 2025 Red Hat, Inc.