[PATCH 3/5] contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than PRId64

Alex Bradbury posted 5 patches 3 months, 2 weeks ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org>
[PATCH 3/5] contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than PRId64
Posted by Alex Bradbury 3 months, 2 weeks ago
qemu_plugin_u64_sum returns a uint64_t, so PRIu64 is the correct format
specifier.

Signed-off-by: Alex Bradbury <asb@igalia.com>
---
 contrib/plugins/hotblocks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index cf4d6b8c36..40d8dae1cd 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/hotblocks.c
@@ -87,7 +87,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
         for (i = 0, it = sorted_counts; i < limit && it; i++, it = it->next) {
             ExecCount *rec = (ExecCount *) it->data;
             g_string_append_printf(
-                report, "0x%016"PRIx64", %d, %ld, %"PRId64"\n",
+                report, "0x%016"PRIx64", %d, %ld, %"PRIu64"\n",
                 rec->start_addr, rec->trans_count,
                 rec->insns,
                 qemu_plugin_u64_sum(
-- 
2.50.1
Re: [PATCH 3/5] contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than PRId64
Posted by Pierrick Bouvier 3 months, 2 weeks ago
On 7/29/25 11:41 PM, Alex Bradbury wrote:
> qemu_plugin_u64_sum returns a uint64_t, so PRIu64 is the correct format
> specifier.
> 
> Signed-off-by: Alex Bradbury <asb@igalia.com>
> ---
>   contrib/plugins/hotblocks.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Re: [PATCH 3/5] contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than PRId64
Posted by Manos Pitsidianakis 3 months, 2 weeks ago
On Wed, Jul 30, 2025 at 4:30 PM Alex Bradbury <asb@igalia.com> wrote:
>
> qemu_plugin_u64_sum returns a uint64_t, so PRIu64 is the correct format
> specifier.
>
> Signed-off-by: Alex Bradbury <asb@igalia.com>
> ---
>  contrib/plugins/hotblocks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
> index cf4d6b8c36..40d8dae1cd 100644
> --- a/contrib/plugins/hotblocks.c
> +++ b/contrib/plugins/hotblocks.c
> @@ -87,7 +87,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
>          for (i = 0, it = sorted_counts; i < limit && it; i++, it = it->next) {
>              ExecCount *rec = (ExecCount *) it->data;
>              g_string_append_printf(
> -                report, "0x%016"PRIx64", %d, %ld, %"PRId64"\n",
> +                report, "0x%016"PRIx64", %d, %ld, %"PRIu64"\n",
>                  rec->start_addr, rec->trans_count,
>                  rec->insns,
>                  qemu_plugin_u64_sum(
> --
> 2.50.1
>
>

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>